Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return with no argument #538

Merged
merged 3 commits into from
Jun 2, 2021
Merged

return with no argument #538

merged 3 commits into from
Jun 2, 2021

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented May 14, 2021 •
edited
Loading

Proposal to make a language change based on the decision in #518.

@zygoloid zygoloid added the proposal A proposal label May 14, 2021
@zygoloid zygoloid requested a review from a team May 14, 2021 22:03
@zygoloid zygoloid added this to Draft in Proposals via automation May 14, 2021
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label May 14, 2021
@zygoloid zygoloid moved this from Draft to RFC in Proposals May 14, 2021
@zygoloid zygoloid marked this pull request as ready for review May 14, 2021 23:52
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label May 14, 2021
jonmeow
jonmeow reviewed May 17, 2021
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost LGTM, but I want to clear up what you mean with the "Require declaration and definition to match" alternative.

proposals/p0538.md Outdated Show resolved Hide resolved
proposals/p0538.md Outdated Show resolved Hide resolved
chandlerc
chandlerc approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all comments are addressed and I think this is ready to land. LGTM.

Thanks to @jonmeow for doing the initial round of review, mostly just confirming that the comments were addressed here.

@chandlerc chandlerc moved this from RFC to Accepted in Proposals Jun 2, 2021
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Jun 2, 2021
@zygoloid zygoloid merged commit 27d5697 into carbon-language:trunk Jun 2, 2021
@jonmeow jonmeow mentioned this pull request Jul 2, 2021
Merged
@geoffromer geoffromer mentioned this pull request Oct 12, 2021
Closed
@zygoloid zygoloid deleted the proposal-return-with-no-argum branch March 11, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow left review comments

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
No open projects
Proposals
Accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zygoloid @chandlerc @jonmeow