Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api file default public #752

Merged
merged 8 commits into from
Sep 21, 2021
Merged

api file default public #752

merged 8 commits into from
Sep 21, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 16, 2021 •
edited

Replace library public-like api behavior with explicit private behavior, mirroring #665

@jonmeow jonmeow added the proposal A proposal label Aug 16, 2021
@jonmeow jonmeow requested a review from a team August 16, 2021 18:20
@jonmeow jonmeow added this to Draft in Proposals via automation Aug 16, 2021
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Aug 16, 2021
@jonmeow jonmeow marked this pull request as ready for review August 16, 2021 20:03
@jonmeow jonmeow requested a review from a team as a code owner August 16, 2021 20:03
@jonmeow jonmeow moved this from Draft to RFC in Proposals Aug 16, 2021
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Aug 16, 2021
chandlerc
chandlerc reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonmeow jonmeow mentioned this pull request Aug 18, 2021
Closed
@jonmeow jonmeow mentioned this pull request Sep 8, 2021
Closed
chandlerc
chandlerc approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, ship it.

proposals/p0752.md Outdated Show resolved Hide resolved
jonmeow and others added 3 commits September 21, 2021 09:29
@jonmeow @chandlerc
Update proposals/p0752.md
8ca03ca 
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
@jonmeow
Prettier
013ea3d
@jonmeow
merge
44eb289
@jonmeow jonmeow merged commit 68f1977 into carbon-language:trunk Sep 21, 2021
Proposals automation moved this from RFC to Accepted Sep 21, 2021
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Sep 21, 2021
@jonmeow jonmeow deleted the proposal-api-file-default-pub branch September 21, 2021 16:33
chandlerc added a commit that referenced this pull request Jun 28, 2022
@jonmeow @chandlerc
api file default public (#752)
6d33a80 
Replace library public-like `api` behavior with explicit `private` behavior, mirroring #665 

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

@josh11b josh11b Awaiting requested review from josh11b

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
No open projects
Proposals
Accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonmeow @chandlerc @josh11b