as expressions #845
Merged
as expressions #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
reviewed
Sep 22, 2021
rather than suggesting it's the semantic foundation of implicit conversions. The lossless + semantics-preserving rules should be sufficient to identify what an implicit conversion does.
unsafe_as -> assume_as.
github-actions
bot
added
the
proposal rfc
geoffromer
reviewed
Sep 27, 2021
Co-authored-by: Geoff Romer <gromer@google.com>
josh11b
reviewed
Oct 6, 2021
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
chandlerc
reviewed
Oct 9, 2021
There was a problem hiding this comment.
This is looking really nice to me. I'm still interested in pushing a bit on the assume_as vs. unsafe_as. But if we're not converging there quickly, I'm also very open to breaking that out into a follow-up change (can even keep some or all of the content and just mark it as WIP / undecided).
Also might make sense to break out at least the discussion to an issue for leads.
jonmeow
reviewed
Oct 12, 2021
This isn't an alternative; it's complementary to the current proposal.
jonmeow
reviewed
Oct 18, 2021
chandlerc
reviewed
Oct 27, 2021
chandlerc
approved these changes
Oct 29, 2021
github-actions
bot
added
proposal accepted
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
This proposal provides an `as` expression for casting. This supports implicit conversions plus some safe and unsurprising conversions that we do not support implicitly: * lossy but fully defined conversions to floating-point types * conversion from `bool` to integer types * conversion between adaptors and their adapted type, and more generally between compatible types This facility can be extended by implementing the `As(TargetType)` interface for a type. Co-authored-by: Geoff Romer <gromer@google.com> Co-authored-by: josh11b <josh11b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal provides an
asexpression for casting. This supports implicit conversions plus some safe and unsurprising conversions that we do not support implicitly:boolto integer typesThis facility can be extended by implementing the
As(TargetType)interface for a type.