Implicit conversions for aggregates #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
proposal rfc
zygoloid
reviewed
Jan 5, 2022
docs/design/classes.md
Outdated
| For example, since | ||
| [comparison between `i32` and `u32` is defined](/proposals/p0702.md#built-in-comparisons-and-implicit-conversions), | ||
| equality comparison between values of types `{.x: i32, .y: i32}` and | ||
| `{.y: u32, .x: u32}` is as well. |
There was a problem hiding this comment.
I think we should say what order the fields are compared in. IIRC we said we'd use the order of the left-hand operand so that the order of operations in == matches =. Eg, "Equality and inequality comparisons compare fields using the field order of the left-hand operand and stop once the outcome of the comparison is determined. However, the comparison order and short-circuiting are generally expected to affect only the performance characteristics of the comparison and not its meaning."
proposals/p0981.md
Outdated
|
|
||
| Rather than picking the left-hand argument's field order when the orders were | ||
| different, we considered requiring the field order to match when performing | ||
| comparisons. An explicit conversion to a common type would be required to |
There was a problem hiding this comment.
Suggested change
| comparisons. An explicit conversion to a common type would be required to | |
| equality comparisons. An explicit conversion to a common type would be required to |
There was a problem hiding this comment.
I made a larger change.
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
|
LGTM as well!!! |
zygoloid
approved these changes
Jan 6, 2022
github-actions
bot
added
proposal accepted
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Define initialization, assignment, comparison, and implicit conversion between data classes with different field orders and/or types. Implements the decision made in #710 . Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define initialization, assignment, comparison, and implicit conversion between data classes with different field orders and/or types.
Implements the decision made in #710 .