New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new components #118
Merged
Merged
add new components #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…mponents into freeman-lab/new-components
freeman-lab
changed the title
add heading, sidenote, and blockquote components
add heading and sidenote components
Feb 2, 2022
katamartin
reviewed
Feb 5, 2022
katamartin
reviewed
Feb 7, 2022
katamartin
reviewed
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add several new components related to our moving common layouts into a separate
layouts
package. These components were identified as being used by those layouts but not really specific to them (and especially not specific to their layout / grid patterns). In some cases these are also components that we use across various places across our sites (unrelated to those layouts).The components are:
Avatar
AvatarGroup
Heading
Sidenote
Caption
TableCaption
FigureCaption
LinkGroup
Colors
One more that is here for now, but could maybe later be moved to
@carbonplan/mdx
package, isBlockquote
. It probably eventually makes sense in an@carbonplan/mdx
package because we plan to explicitly use it as an override of MDX elements.As part of this, I also made a couple tweaks to
Group
.