Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable JDK 17 matrix builds #6

Merged
merged 6 commits into from
Oct 27, 2021
Merged

Enable JDK 17 matrix builds #6

merged 6 commits into from
Oct 27, 2021

Conversation

grevend-bosch
Copy link
Contributor

Signed-off-by: David Greven fixed-term.David.Greven@de.bosch.com

@grevend-bosch
Enable JDK 17 matrix build
fb36da4 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch grevend-bosch added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2021
@grevend-bosch grevend-bosch self-assigned this Oct 25, 2021
@grevend-bosch grevend-bosch added this to In Progress in Platform via automation Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #6 (a678328) into master (758ad6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage     97.72%   97.72%           
  Complexity       17       17           
=========================================
  Files             1        1           
  Lines            44       44           
  Branches          4        4           
=========================================
  Hits             43       43           
  Partials          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758ad6e...a678328. Read the comment docs.

@grevend-bosch grevend-bosch linked an issue Oct 25, 2021 that may be closed by this pull request
Enable JDK 17 matrix builds #5
Closed
@grevend-bosch
Update NOTICE.md
0a15322 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
strieflin
strieflin requested changes Oct 25, 2021
View reviewed changes
NOTICE.md Outdated Show resolved Hide resolved
Platform automation moved this from In Progress to Review in Progress Oct 25, 2021
@grevend-bosch
Update NOTICE.md
662cf29 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch
Remove dependency
b41eb29 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch
Revert "Remove dependency"
dae80de 
This reverts commit b41eb29.

Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Platform automation moved this from Review in Progress to Reviewer Approved Oct 25, 2021
strieflin
strieflin previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grevend-bosch
Fix workflow link
a678328 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Platform automation moved this from Reviewer Approved to Review in Progress Oct 25, 2021
Platform automation moved this from Reviewer Approved to Review in Progress Oct 25, 2021
strieflin
strieflin requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as for carbynestack/java-http-client#8: "test" check fails. Has to be resolved before merging.

@grevend-bosch
Copy link
Contributor Author

Same here as for carbynestack/java-http-client#8: "test" check fails. Has to be resolved before merging.

The test check is actually not failing, it just does not exist anymore. But since we required the old workflow to run before merging, it keeps on waiting (forever) for the status to be reported. @strieflin Therefore it would be vital that you change the branch configuration to require the new test and build jobs to pass.

strieflin
strieflin approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Branch check settings have been updated.

Platform automation moved this from Review in Progress to Reviewer Approved Oct 27, 2021
@strieflin strieflin merged commit 6e1b975 into master Oct 27, 2021
Platform automation moved this from Reviewer Approved to Done Oct 27, 2021
@strieflin strieflin deleted the jdk17-matrix-build branch October 27, 2021 08:15
@grevend-bosch grevend-bosch mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strieflin strieflin strieflin approved these changes

@sbckr sbckr Awaiting requested review from sbckr

Assignees

@grevend-bosch grevend-bosch

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Platform
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable JDK 17 matrix builds
2 participants
@grevend-bosch @strieflin