Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0025 <asset_name> encoding #191

Closed
mkazlauskas opened this issue Jan 13, 2022 · 2 comments
Closed

CIP-0025 <asset_name> encoding #191

mkazlauskas opened this issue Jan 13, 2022 · 2 comments

Comments

@mkazlauskas
Copy link

It is not clear what encoding should <asset_name> be. I originally assumed it to be hex, but it seems that people are using utf8. It would be great to specify it explicitly in the CIP. @alessandrokonrad
@alessandrokonrad
Copy link
Contributor

alessandrokonrad commented Jan 13, 2022 •
edited
Loading

Yeah that was a mistake, the default encoding here is utf8 now, since pretty much everyone is using it.
hex would definitely be better and I would suggest having that in a version 2 of the NFT metadata standard. So we can keep backwards compatibility for the current format.

@KtorZ
Copy link
Member

KtorZ commented Jan 25, 2022

Addressed in #193

@KtorZ KtorZ closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkazlauskas @KtorZ @alessandrokonrad