Specified asset name encoding #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Approving with mixed feelings since asset names are not necessarily representable as valid UTF-8 byte sequences! This is mildly okay in this context because it only excludes those non representable asset-name from complying with this CIP.
Version 2 would need to address this issue.
SebastienGllmt
approved these changes
Jan 25, 2022
crptmppt
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the encoding was never really specified for asset names and most projects use
UFT-8,UTF-8is now the standard for version1.0. All future versions will use thehexencoding for asset names. Then we can also keep backwards compatibility.