Update line numbers of cardano-serialisation-lib

[thisHermit]

No description provided.

[rphair]

Looks accurate. The current links on CIP-0008 don't point anywhere in particular in that file.

So approving as is but @SebastienGllmt maybe there's a more general way to refer to these code segments that will still work even if the code shifts around some more?

[thisHermit]

I see a way to point to a particular commit. Would that be an acceptable improvement?

[SebastienGllmt]

Github allows generating permalinks for files which will be more stable than the change you made

[rphair]

I only know of linking to a specific commit, which will also also change (along with the line number) when the code is updated. What's the secret, @SebastienGllmt ... or is it best just to link to the file itself?
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet

[rphair]

never mind that last comment... yes @thisHermit I think linking to the commit & line number would be fine since you're only trying to show that section of code, not necessarily its latest content (I was just hoping someone might know how to add some other type of anchor to search in the file, e.g a regex)

[rphair]

@SebastienGllmt is there an example somewhere that doesn't use Replit anonymously, so the code (pointed to on line 127) can be viewed without forking the repl?

[SebastienGllmt]

no I don't know any good alternative

[KtorZ]

I think the issue with repl.it is orthogonal to that PR. So, happy to merge this change now, and perhaps move the repl.it discussion to github issues