Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0036 | Adding the deregistration metadata format #349

Merged
merged 6 commits into from Oct 18, 2022

Conversation

gitmachtl
Copy link
Contributor

@gitmachtl gitmachtl commented Oct 8, 2022

  • Adding the deregistration metadata format to the README.md and the schema.cddl
  • The deregistration metadata uses the key 61286 and is independent from the registration metadata which uses key 61284
  • Updating CIP-0010 (metadata datum registry), description for key 61285(witness) and 61286(deregistration)

@rphair
Copy link
Collaborator

rphair commented Oct 8, 2022

@gitmachtl
Copy link
Contributor Author

so, this should now be the final PR hopefully 😄
we had a discussion, and @kevinhammond agreed, that the until now unused but reserved key 61286 could be used to add a deregistration metadata format. this is independent from the registration metadata format and that part of CIP-0036 is untouched. the specification is currently only for the voting_purpose=0 (Catalyst). other voting_purpose values (voting-chains) may use a different way to specify a deregistration. the goal was that to always produce valid registration metadata and not abuse the use of an invalid registration metadata to act like a deregistration. this addition in the PR should now give a clear format if users/tools want to do a de-registration of the stake credentials on the catalyst voting chain.

@kevinhammond
Copy link
Contributor

we had a discussion, and @kevinhammond agreed, that the until now unused but reserved key 61286 could be used to add a deregistration metadata format.

Yes

the specification is currently only for the voting_purpose=0 (Catalyst). other voting_purpose values (voting-chains) may use a different way to specify a deregistration.

Technically, this is specific to Catalyst voting on the corresponding Jormungandr voting chains (it is possible that purpose 0 might also be collated and used by a third party, for example, as a generic/non-specific vote delegation).

@kevinhammond
Copy link
Contributor

The main reason for not wanting to use eg an empty delegation array or second metadata format for deregistration purposes is that this creates complication for hardware wallets (perhaps two apps are needed).

@gitmachtl
Copy link
Contributor Author

There is no need imo that hardware wallets have to support all features, thats why i wrote the line:
https://github.com/cardano-foundation/CIPs/blame/6e2cf66230bf662b04065ec75098f27695045fcc/CIP-0036/README.md#L154

I don't see a problem if deregistraton would not be supported on hardware wallets.

Copy link
Collaborator

@SebastienGllmt SebastienGllmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The main reason for not wanting to use eg an empty delegation array or second metadata format for deregistration purposes is that this creates complication for hardware wallets (perhaps two apps are needed).

may be good to give a rationale for this in the CIP

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense 👍 @gitmachtl are you ready for this to be merged?

@rphair
Copy link
Collaborator

rphair commented Oct 18, 2022

OK, this all seems in order then 😎

@rphair rphair merged commit 6572921 into cardano-foundation:master Oct 18, 2022
@gitmachtl gitmachtl deleted the patch-4 branch October 22, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants