Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links from CIPs to hydra.iohk.io #487

Merged

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Mar 23, 2023

Fixes #485. Readers and authors on CIP repository and Developer Portal reported links from CIPs to reference papers were out of date due to hydra.iohk.io being superseded.

@Ryun1 identified IntersectMBO/cardano-ledger@7bb0993 which has been helpful in narrowing down the target documents at their new locations. Before we merge this I hope we can get approval or correction from the CIP authors and representative paper authors that the new link targets are appropriate:

cc @gufmar @alessandrokonrad @SmaugPool @JaredCorduan @ADARobinHood @KtorZ @disassembler @dcoutts @WhatisRT

CIPs affected (see reference issue for details):

  • CIP-0006
  • CIP-0025
  • CIP-0059
  • CIP-0074
  • CIP-1854
  • CIP-1855

@rphair rphair added the Correction Fixing minor issue or typo label Mar 23, 2023
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Ryun1 and @rphair ! The new links are what I expect.

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together @rphair

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@KtorZ KtorZ merged commit 5bcdb9b into cardano-foundation:master Mar 30, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP links to hydra.iohk.io are all broken
4 participants