Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0060 | Fix relative links #525

Merged
merged 2 commits into from Jul 4, 2023

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jun 21, 2023

The Developer Portal build of the CIP directory structure depends on relative links being prefixed by ./ so this is a routine fix that comes up from time to time (we are gradually getting to all of these).

Not sure why these problems aren't all exposed at once, but local builds of the Dev Poral generate warnings like these for relative pathnames and often expand the absolute URL wrong (cc @katomm):

[WARNING] Docusaurus found broken links!

Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

Exhaustive list of all broken links found:

- On source page path = /docs/governance/cardano-improvement-proposals/CIP-0060:
   -> linking to cddl/version-2.cddl (resolved as: /docs/governance/cardano-improvement-proposals/cddl/version-2.cddl)

@rphair rphair added the Correction Fixing minor issue or typo label Jun 21, 2023
@rphair rphair requested review from KtorZ and Ryun1 June 21, 2023 08:30
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 🚀

@KtorZ KtorZ merged commit f59854d into cardano-foundation:master Jul 4, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Jul 28, 2023
* added current directory prefix to relative links

* line break between two links, while we're at it
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
* added current directory prefix to relative links

* line break between two links, while we're at it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants