Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top README: update for CIP-0084 consequences to RSS proposals #536

Merged

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jul 2, 2023

As previously arranged in #456 (comment), RSS proposals can all be given a status of Proposed and category of Ledger now that CIP-0084 is merged with a language clarification both extending & limiting the Ledger team's responsibility for these CIPs (quoted in #456 (comment)).

More recent CIPs written according to the updated CIP-0001 (0075, 0082: cc @TobiasFancee) have their Inactive status removed and no longer have a strike-out on the CIP table. (re: #482)

Older CIPs also now have status Proposed in the top level table, and will soon be updated for compatibility with CIP-0001 with headers fixed to use the new status & other fields:

Note CIP-0024 is mainly updated in name since it doesn't propose RSS changes or affect the Ledger but only recommends changes to Daedalus (and perhaps the Cardano white paper).

(CPS-0007 promotion on the top level page is only incidental here... irrelevant to the main subject but we don't want too many merge conflicts from concurrent updates to the top level README.)

@rphair rphair added the Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information label Jul 2, 2023
@Ryun1
Copy link
Collaborator

Ryun1 commented Jul 2, 2023

These changes look good to me, glad we got this cleared up🚀

Should we also remove the Reward-Sharing Schema category from the CIP template here and the CPS template here?

@rphair
Copy link
Collaborator Author

rphair commented Jul 3, 2023

Should we also remove the Reward-Sharing Schema category from the CIP template[s]

yes @Ryun1 of course we should: thanks for spotting that. This is embarrassing but I've never seen those files before. 😖 We also missed removing the category in #482 🙏

@Ryun1
Copy link
Collaborator

Ryun1 commented Jul 3, 2023

We also missed removing the category in #482 🙏

I spotted this error after and I have been waiting for a suitable PR to make the change in - I didnt think it was worth it's own PR...

README.md Outdated Show resolved Hide resolved
@rphair rphair requested a review from Ryun1 July 3, 2023 13:34
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, provided that #537 and #538 are also merged in a timely manner after.

@rphair
Copy link
Collaborator Author

rphair commented Jul 4, 2023

sure @KtorZ - I'll do the 2 remaining #533 and #535 as soon as we answer the question in #537 (comment) 🤓

@rphair rphair merged commit d1c21f7 into cardano-foundation:master Jul 4, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Jul 28, 2023
…o-foundation#536)

* update top README for CIP-0084 consequences to RSS proposals

* incidental cip75 indentation fix for proper outline form

* remove RSS (folding into Ledger) in .github templates

* placed CIP-1694 correctly in numerical order
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
…o-foundation#536)

* update top README for CIP-0084 consequences to RSS proposals

* incidental cip75 indentation fix for proper outline form

* remove RSS (folding into Ledger) in .github templates

* placed CIP-1694 correctly in numerical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants