Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0107? | URI Scheme - Block and transaction objects #635

Merged
merged 8 commits into from
Jul 14, 2024

Conversation

Quantumplation
Copy link
Contributor

@Quantumplation Quantumplation commented Dec 11, 2023

This CIP extends CIP-0013 with two new authorities, and enabling a simple and canonical reference to 5 new objects or locations on the Cardano blockchain.

In particular, this will be useful in CIP-100, where we want to allow users to make references to on-chain transactions, blocks, and metadata, or store the transaction metadata within the same transaction.

Rendered

This CIP extends CIP-0013 with two new authorities, and enabling a simple and canonical reference to 5 new objects or locations on the Cardano blockchain
@rphair rphair added the Category: Tools Proposals belonging to the 'Tools' category. label Dec 11, 2023
@rphair rphair changed the title CIP-???? | Extend CIP-0013 with new authorities for common objects CIP-???? | URI Scheme - Block and transaction objects Dec 11, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quantumplation I am really happy to see this presented, especially with concurrent discussion of #625 highlighting that objects should be possible to reference independently of query providers (cc @klntsky).

CIP-?/README.md Outdated Show resolved Hide resolved
CIP-?/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator

rphair commented Dec 11, 2023

@Quantumplation on agenda for quick Triage assessment in next CIP meeting on 12 December, if you can make it (this is our last CIP meeting for 4 weeks): https://hackmd.io/@cip-editors/78

Co-authored-by: Robert Phair <rphair@cosd.com>
@Quantumplation
Copy link
Contributor Author

@rphair I am planning on being there for the CIP-0100 approval as well :)

Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, easy, and clear to me at first reading. See no reason why it should not be adopted. :)

CIP-?/README.md Outdated Show resolved Hide resolved
CIP-?/README.md Outdated Show resolved Hide resolved
CIP-?/README.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Dean <63186174+Crypto2099@users.noreply.github.com>
CIP-?/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CIP-???? | URI Scheme - Block and transaction objects CIP-0107? | URI Scheme - Block and transaction objects Dec 12, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quantumplation you are all set to rename the directory to CIP-0107 and update your "Rendered" link accordingly 🎉 ...

CIP-?/README.md Outdated Show resolved Hide resolved
@Quantumplation
Copy link
Contributor Author

Done and Done.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quantumplation given that a new span of URI protocols + a containing CPS (#841) are now moving ahead together, I would happily approve & merge this as soon as we settle the question about whether & how the ?height= query is used as per currently unresolved discussions:
#635 (comment)
#635 (comment)

I would prefer a consensus to keep height= in the syntax, despite its lack of cryptographic certainty, since I believe it would likely be a popular choice when this URI syntax becomes more generally adopted.

Specifically, I would not want to be the one to be explain to members of the public why they couldn't use it (in historical and/or governance contexts as I argued for in #635 (comment)) when it is meaningful for a far greater time span (in hindsight, forever) than its period of uncertainty (contemporary with its creation).

In any case as soon as there is a consensus about height=, and the CIP is updated according to that consensus, I'm ready to approve this. Adding to CIP meeting 9 days from now (https://hackmd.io/@cip-editors/91) to make sure this is progressed & maybe even merge if the way is cleared in the ensuring discussion here. cc @Crypto2099


Examples:
```
web+cardano://block/c6a8976125193dfae11551c5e80a217403d953c08ebbd69bba904d990854011f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1 of 2) If height= is preserved in the query part of the URI syntax documented below, an example should be added here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. should be considered along with @Crypto2099's #635 (comment).


```
blockref = "//block" query
query = ( "?block=" block_hash | "?height=" block_height)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(2 of 2) If height= is eliminated due to reservations about immutability (as per the previous & current discussion), it should be removed here.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quantumplation revisiting this CIP was favourable at the editors' meeting tonight & we're looking forward to merging as soon as @Crypto2099 commits final adjustments including resolving the dialogue above (I'm ready to approve it after those update(s)).

@rphair rphair requested a review from Crypto2099 June 28, 2024 15:02
@rphair
Copy link
Collaborator

rphair commented Jun 30, 2024

Per last meeting (# 91), expecting some final updates to this PR & likely merge by next meeting, so marking Last Check & putting on agenda: https://hackmd.io/@cip-editors/92 (cc @Crypto2099)

@rphair rphair added the Last Check This proposal has been reviewed and approved, staged for merging. label Jun 30, 2024
@rphair rphair requested a review from Ryun1 July 1, 2024 16:16
CIP-0107/README.md Outdated Show resolved Hide resolved
@Ryun1
Copy link
Collaborator

Ryun1 commented Jul 9, 2024

In the pull request, it is probably a good idea to update the reference to this proposal within CIP-100 - here.

CIP-0107/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to see this one FINALLY get merged if @Quantumplation can take a quick glance at the last outstanding/remaining issues (examples and minor cross-linking suggestions).

Quantumplation and others added 2 commits July 14, 2024 09:37
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Adam Dean <63186174+Crypto2099@users.noreply.github.com>
@Quantumplation
Copy link
Contributor Author

@Crypto2099 I just applied the two suggestions; were there others you were thinking of? I haven't been able to keep up with this super well.

@Crypto2099
Copy link
Collaborator

@Crypto2099 I just applied the two suggestions; were there others you were thinking of? I haven't been able to keep up with this super well.

Looks like everything outstanding/pending has been resolved so I think this one is ready to merge IMO @Ryun1 @rphair

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Crypto2099 @Quantumplation for pushing this one through. 👏

@rphair rphair merged commit 49c64d4 into cardano-foundation:master Jul 14, 2024
@Quantumplation Quantumplation deleted the cip-13-extension branch July 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tools Proposals belonging to the 'Tools' category. Last Check This proposal has been reviewed and approved, staged for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants