Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/cardano graphql 0.3.0 upgrade #76

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Chore/cardano graphql 0.3.0 upgrade #76

merged 6 commits into from
Nov 7, 2019

Conversation

rhyslbw
Copy link
Collaborator

@rhyslbw rhyslbw commented Nov 7, 2019 •
edited
Loading

Also some fixes:

  • Includes block creator
  • Scopes Epoch blocks count to exclude EBBs and the genesis, which in this context are not important.
  • Lovelaces converted to Ada
  • Changelog has been cleared, as the changes are only relevant post release.

Edit: Updates the lodash webpack plugin config to enable deep property path selection, cleaning up the mess of guards

@rhyslbw rhyslbw added the chore label Nov 7, 2019
@rhyslbw rhyslbw added this to In progress in Support Incentivized Testnet via automation Nov 7, 2019
@rhyslbw rhyslbw removed the request for review from Sam-Jeston November 7, 2019 05:11
@rhyslbw rhyslbw mentioned this pull request Nov 7, 2019
Closed
@rhyslbw
Revert implementation of lodash.get due to unexpected behaviour, scop…
64c6122 
…e epoch blocks to remove EBBs and Genesis from count
Support Incentivized Testnet automation moved this from In progress to Reviewer approved Nov 7, 2019
Sam-Jeston
Sam-Jeston approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@Sam-Jeston Sam-Jeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. lovelacesToAda is correct.

I'd consider changing all the instances of the syntax that I have highlighted, but up to you

source/features/blocks/api/transformers.ts Outdated Show resolved Hide resolved
@rhyslbw rhyslbw mentioned this pull request Nov 7, 2019
Closed
@rhyslbw rhyslbw merged commit 7825cd0 into develop Nov 7, 2019
Support Incentivized Testnet automation moved this from Reviewer approved to Done Nov 7, 2019
@rhyslbw rhyslbw deleted the chore/cardano-graphql-0.3.0-upgrade branch November 7, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sam-Jeston Sam-Jeston Sam-Jeston approved these changes

Assignees
No one assigned
Labels
chore
Projects
No open projects
Support Incentivized Testnet
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhyslbw @Sam-Jeston