refactor: sonar issues

cardano-foundation · May 3, 2024 · 04f298e · 04f298e
1 parent 36f1be1
commit 04f298e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/...ain/java/org/cardanofoundation/rosetta/api/block/mapper/StakeRegistrationToOperation.java b/...ain/java/org/cardanofoundation/rosetta/api/block/mapper/StakeRegistrationToOperation.java
@@ -40,10 +40,12 @@ private String convert(CertificateType model) {
     if (model == null) {
       return null;
     } else {
-      return model.equals(CertificateType.STAKE_REGISTRATION)
-          ? OperationType.STAKE_KEY_REGISTRATION.getValue() :
-          model.equals(CertificateType.STAKE_DEREGISTRATION)
-              ? OperationType.STAKE_KEY_DEREGISTRATION.getValue() : null;
+      if(model.equals(CertificateType.STAKE_REGISTRATION)) {
+        return OperationType.STAKE_KEY_REGISTRATION.getValue();
+      } else {
+        return model.equals(CertificateType.STAKE_DEREGISTRATION)
+            ? OperationType.STAKE_KEY_DEREGISTRATION.getValue() : null;
+      }
     }
   }
 

diff --git a/...ain/java/org/cardanofoundation/rosetta/api/block/model/domain/PoolRegistrationParams.java b/...ain/java/org/cardanofoundation/rosetta/api/block/model/domain/PoolRegistrationParams.java
diff --git a/api/src/main/java/org/cardanofoundation/rosetta/api/block/model/domain/ProtocolParams.java b/api/src/main/java/org/cardanofoundation/rosetta/api/block/model/domain/ProtocolParams.java
@@ -42,7 +42,6 @@ public class ProtocolParams {
 
   private BigInteger minPoolCost; //16
   private BigInteger adaPerUtxoByte; //17
-  //private String nonce;
 
   //Alonzo changes
   private Map<String, long[]> costModels; //18

diff --git a/.../main/java/org/cardanofoundation/rosetta/api/block/model/entity/ProtocolParamsEntity.java b/.../main/java/org/cardanofoundation/rosetta/api/block/model/entity/ProtocolParamsEntity.java
@@ -44,7 +44,6 @@ public class ProtocolParamsEntity {
 
   private BigInteger minPoolCost; //16
   private BigInteger adaPerUtxoByte; //17
-  //private String nonce;
 
   //Alonzo changes
   private Map<String, long[]> costModels; //18