refactor: further code smells

cardano-foundation · May 7, 2024 · cacec00 · cacec00
1 parent 422d67e
commit cacec00
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/.../java/org/cardanofoundation/rosetta/api/block/mapper/BlockTxToRosettaTransactionTest.java b/.../java/org/cardanofoundation/rosetta/api/block/mapper/BlockTxToRosettaTransactionTest.java
@@ -269,7 +269,7 @@ void toDto_Test_getOutputsAsOperations() {
 
     assertThat(opInto.getRelatedOperations()).isNotNull();
     assertThat(opInto.getRelatedOperations().size()).isEqualTo(1);
-    assertThat(opInto.getRelatedOperations().getFirst().getIndex()).isEqualTo(0);
+    assertThat(opInto.getRelatedOperations().getFirst().getIndex()).isZero();
 
     CoinChange coinChange = opInto.getCoinChange();
     assertThat(coinChange.getCoinAction()).isEqualTo(CoinAction.CREATED);

diff --git a/api/src/test/java/org/cardanofoundation/rosetta/api/network/NetworkServiceImplTest.java b/api/src/test/java/org/cardanofoundation/rosetta/api/network/NetworkServiceImplTest.java
@@ -14,19 +14,19 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class NetworkServiceImplTest extends IntegrationTest {
+class NetworkServiceImplTest extends IntegrationTest {
 
   @Autowired
   private NetworkService networkService;
 
   @Test
-  public void verifyCorrectNetworkTest() {
+  void verifyCorrectNetworkTest() {
     // void function, no exception expected
     networkService.verifyNetworkRequest(createNetworkIdentifier(Constants.CARDANO_BLOCKCHAIN, Constants.DEVKIT));
   }
 
   @Test
-  public void verifyWrongNetworkTest() {
+  void verifyWrongNetworkTest() {
     ApiException apiException = assertThrows(ApiException.class,
         () -> networkService.verifyNetworkRequest(createNetworkIdentifier(Constants.CARDANO_BLOCKCHAIN,
             Constants.MAINNET)));
@@ -35,7 +35,7 @@ public void verifyWrongNetworkTest() {
   }
 
   @Test
-  public void verifyWrongBlockchainTest() {
+  void verifyWrongBlockchainTest() {
     ApiException apiException = assertThrows(ApiException.class,
         () -> networkService.verifyNetworkRequest(createNetworkIdentifier("Wrong Blockchain",
             Constants.DEVKIT)));

diff --git a/.../test/java/org/cardanofoundation/rosetta/common/services/impl/CardanoServiceImplTest.java b/.../test/java/org/cardanofoundation/rosetta/common/services/impl/CardanoServiceImplTest.java
@@ -247,9 +247,9 @@ void submitTransactionTest_tx_error() {
     } catch (ApiException e) {
       //then
       Error error = e.getError();
-      assertEquals(error.getCode(), 5006);
-      assertEquals(error.getMessage(), "Error when sending the transaction");
-      assertEquals(error.getDescription(), "Transaction hash format error: err");
+      assertEquals(5006, error.getCode());
+      assertEquals("Error when sending the transaction", error.getMessage());
+      assertEquals("Transaction hash format error: err", error.getDescription());
     }
   }
 
@@ -266,9 +266,9 @@ void submitTransactionTest_tx_submit_error() {
     } catch (ApiException e) {
       //then
       Error error = e.getError();
-      assertEquals(error.getCode(), 5006);
-      assertEquals(error.getMessage(), "Error when sending the transaction");
-      assertEquals(error.getDescription(), "Transaction submit error: err");
+      assertEquals(5006, error.getCode());
+      assertEquals("Error when sending the transaction", error.getMessage());
+      assertEquals("Transaction submit error: err", error.getDescription());
     }
   }