docs: Allow redelegation to the same pool in Conway (#4562) <!-- Deta…

…il in a few bullet points the work accomplished in this PR. Before you submit, don't forget to: CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml hie.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml hie.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml hie.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> - [x] Change of re-delegation logic. - [x] Adjust unit tests - [x] Add new unit tests - [x] Add integration testing showing the case - [x] Babbage: re-delegation to the same pool -> ERROR - [x] Conway: re-delegation to the same pool -> ERROR - [x] Conway: re-delegation to the same pool + new vote or re-vote other than recent -> OK - [x] Conway: re-delegation to the same pool + vote the same again -> ERROR - [x] Conway: re-delegation to the different pool + vote the same again -> OK - [x] Conway: vote the same again -> ERROR - [x] check joinStakePools - [x] add handleDelegationVoteRequest ### Comments In order to run integration tests do the following: (a) Babbage ``` just integration-tests-cabal-match TRANS_NEW_JOIN_01f ``` (b) Conway ``` just conway-integration-tests-cabal-match TRANS_NEW_JOIN_01f ``` <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number adp 3312 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Source commit: cb43316

api/edge/swagger.yaml

@@ -5200,11 +5200,33 @@ x-errPoolAlreadyJoined: &errPoolAlreadyJoined
   properties:
     message:
       type: string
-      description: May occur when a given poolId matches the current delegation preferences of the wallet's account.
+      description: May occur when a given poolId matches the current delegation preferences of the wallet's account (not in Conway onwards provided different vote was also casted).
     code:
       type: string
       enum: ['pool_already_joined']
 
+x-errPoolAlreadyJoinedSameVote: &errPoolAlreadyJoinedSameVote
+  <<: *responsesErr
+  title: pool_already_joined_same_vote
+  properties:
+    message:
+      type: string
+      description: May occur in Conway onwards when a given poolId matches the current delegation preferences of the wallet's account and also the same vote was cast.
+    code:
+      type: string
+      enum: ['pool_already_joined_same_vote']
+
+x-errSameVote: &errSameVote
+  <<: *responsesErr
+  title: same_vote
+  properties:
+    message:
+      type: string
+      description: May occur in Conway onwards when the same vote was cast.
+    code:
+      type: string
+      enum: ['same_vote']
+
 x-errNotDelegatingTo: &errNotDelegatingTo
   <<: *responsesErr
   title: not_delegating_to
@@ -6313,6 +6335,8 @@ x-responsesJoinStakePool: &responsesJoinStakePool
             - <<: *errNoUtxosAvailable
             - <<: *errWrongEncryptionPassphrase
             - <<: *errPoolAlreadyJoined
+            - <<: *errPoolAlreadyJoinedSameVote
+            - <<: *errSameVote
   404:
     description: Not Found
     content: