Skip to content

Commit

Permalink
Don't retry tests that deplete a fixture wallet's funds.
Browse files Browse the repository at this point in the history
If such a test fails when run the first time, it's more than likely that
it'll fail when run a second time (as a fixture wallet's funds can only
be spent once).

In response to review feedback:

#2644 (comment)
  • Loading branch information
jonathanknowles committed May 13, 2021
1 parent ce4e6ee commit aef4f52
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ spec = describe "BYRON_MIGRATIONS" $ do
testAddressCycling "Icarus" fixtureIcarusWallet 3
testAddressCycling "Icarus" fixtureIcarusWallet 10

it "BYRON_MIGRATE_02 - \
Hspec.it "BYRON_MIGRATE_02 - \
\Can migrate a large wallet requiring more than one transaction."
$ \ctx -> runResourceT @IO $ do

Expand Down Expand Up @@ -382,10 +382,10 @@ spec = describe "BYRON_MIGRATIONS" $ do
, expectErrorMessage (errMsg403NothingToMigrate sourceWalletId)
]

it "BYRON_MIGRATE_04 - \
Hspec.it "BYRON_MIGRATE_04 - \
\Actual fee for migration is identical to predicted fee."
$ \ctx -> forM_ [fixtureRandomWallet, fixtureIcarusWallet]
$ \fixtureByronWallet -> runResourceT $ do
$ \fixtureByronWallet -> runResourceT @IO $ do

let feeExpected = 334_200

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ spec = describe "SHELLEY_MIGRATIONS" $ do
testAddressCycling 3
testAddressCycling 10

it "SHELLEY_MIGRATE_02 - \
Hspec.it "SHELLEY_MIGRATE_02 - \
\Can migrate a large wallet requiring more than one transaction."
$ \ctx -> runResourceT @IO $ do

Expand Down Expand Up @@ -362,9 +362,9 @@ spec = describe "SHELLEY_MIGRATIONS" $ do
, expectErrorMessage (errMsg403NothingToMigrate sourceWalletId)
]

it "SHELLEY_MIGRATE_04 - \
Hspec.it "SHELLEY_MIGRATE_04 - \
\Actual fee for migration is identical to predicted fee."
$ \ctx -> runResourceT $ do
$ \ctx -> runResourceT @IO $ do

let feeExpected = 255_200

Expand Down

0 comments on commit aef4f52

Please sign in to comment.