Use explicit field names when constructing TxUpdate objects.

cardano-foundation · Apr 30, 2024 · ffcf15b · ffcf15b
1 parent 1c081a9
commit ffcf15b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/lib/balance-tx/lib/internal/Internal/Cardano/Write/Tx/Balance.hs b/lib/balance-tx/lib/internal/Internal/Cardano/Write/Tx/Balance.hs
@@ -862,7 +862,13 @@ balanceTxInner
                     tx
                     timelockKeyWitnessCounts
             minfee = Convert.toWalletCoin $ evaluateMinimumFee pp tx witCount
-            update = TxUpdate [] [] [] [] (UseNewTxFee minfee)
+            update = TxUpdate
+                { extraInputs = []
+                , extraCollateral = []
+                , extraOutputs = []
+                , extraInputScripts = []
+                , feeUpdate = UseNewTxFee minfee
+                }
         tx' <- left updateTxErrorToBalanceTxError $ updateTx tx update
         let balance = txBalance tx'
             minfee' = Convert.toLedgerCoin minfee
@@ -1167,7 +1173,13 @@ data TxUpdate = TxUpdate
 --      == Right tx or Left
 -- @
 noTxUpdate :: TxUpdate
-noTxUpdate = TxUpdate [] [] [] [] UseOldTxFee
+noTxUpdate = TxUpdate
+    { extraInputs = []
+    , extraCollateral = []
+    , extraOutputs = []
+    , extraInputScripts = []
+    , feeUpdate = UseOldTxFee
+    }
 
 -- | Method to use when updating the fee of a transaction.
 data TxFeeUpdate

diff --git a/lib/balance-tx/test/spec/Internal/Cardano/Write/Tx/BalanceSpec.hs b/lib/balance-tx/test/spec/Internal/Cardano/Write/Tx/BalanceSpec.hs
@@ -289,7 +289,7 @@ import Internal.Cardano.Write.Tx.Balance
     , PartialTx (..)
     , Redeemer (..)
     , TxFeeUpdate (UseNewTxFee)
-    , TxUpdate (TxUpdate)
+    , TxUpdate (..)
     , UTxOAssumptions (..)
     , balanceTx
     , constructUTxOIndex
@@ -1542,7 +1542,13 @@ prop_updateTx
     -> W.Coin
     -> Property
 prop_updateTx tx extraIns extraCol extraOuts newFee = do
-    let extra = TxUpdate extraIns extraCol extraOuts [] (UseNewTxFee newFee)
+    let extra = TxUpdate
+            { extraInputs = extraIns
+            , extraCollateral = extraCol
+            , extraOutputs = extraOuts
+            , extraInputScripts = []
+            , feeUpdate = UseNewTxFee newFee
+            }
     let tx' = either (error . show) id
             $ updateTx tx extra
     conjoin