Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Jörmungandr tests are failing #2020

Closed
KtorZ opened this issue Aug 11, 2020 · 4 comments
Closed

Nightly Jörmungandr tests are failing #2020

KtorZ opened this issue Aug 11, 2020 · 4 comments
Assignees
@piotr-iohk
Labels
Bug PRIORITY:HIGH Require immediate attention. SEVERITY:LOW Small defects which does not prevent any crucial functionality to work.

Comments

@KtorZ
Copy link
Member

KtorZ commented Aug 11, 2020 •
edited by rvl
Loading

Context

https://buildkite.com/input-output-hk/cardano-wallet/builds/9809

Test Case

  • The jormungandr unit test suite is timing out.
  • The jormungandr integration tests are failing.

Failure / Counter-example

Resolution

QA
@KtorZ KtorZ added this to Backlog in Adrestia via automation Aug 11, 2020
@KtorZ KtorZ added BUG:MINOR and removed BUG:MAJOR labels Aug 11, 2020
@rvl
Copy link
Contributor

rvl commented Aug 11, 2020

It says jormungandr-integration failed and cardano-wallet-jormungandr:test:unit timed out.
You can find logs in the "Artifacts" tab of the build.
The last thing I see in the cardano-wallet-jormungandr test logs is the Cardano.Wallet.Jormungandr.Binary Decoding tests. But they would not be the cause.

@KtorZ KtorZ added Bug SEVERITY:LOW Small defects which does not prevent any crucial functionality to work. PRIORITY:HIGH Require immediate attention. and removed BUG:MAJOR labels Aug 12, 2020
@rvl
Copy link
Contributor

rvl commented Aug 13, 2020

Is it possible that the jormungandr integration tests fail because they don't have built-in retrying like the shelley integration tests?

@KtorZ
Copy link
Member Author

KtorZ commented Aug 13, 2020

@rvl we introduced the retrying it for the Shelley integration tests because of the frequent rollbacks we had. We never had such issues on Jörmungandr because the self-node doesn't rollback as often (or rollback at all actually...). So my two cents would be: no, it is unlikely.

@piotr-iohk piotr-iohk moved this from Backlog to QA in Adrestia Sep 21, 2020
@piotr-iohk piotr-iohk self-assigned this Sep 21, 2020
@piotr-iohk piotr-iohk mentioned this issue Sep 23, 2020
Merged
iohk-bors bot added a commit that referenced this issue Sep 23, 2020
@iohk-bors
Merge #2168 #2171
37e8b51 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=KtorZ a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


2171: Fix metadata examples in swagger.yaml r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 4a547f9
  Fix metadata examples in swagger.yaml



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 23, 2020
@iohk-bors
Merge #2168
e2ddfd6 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=KtorZ a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 23, 2020
@iohk-bors
Merge #2168
0772071 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 24, 2020
@iohk-bors
Merge #2168
c8d45c7 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 24, 2020
@iohk-bors
Merge #2168
e424943 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 24, 2020
@iohk-bors
Merge #2168
4b44550 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 24, 2020
@iohk-bors
Merge #2168
76730e1 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 25, 2020
@iohk-bors
Merge #2168
f5f689e 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@piotr-iohk
Copy link
Contributor

Tests should be passing now.

Adrestia automation moved this from QA to Closed Sep 25, 2020
@CharlesMorgan-IOHK CharlesMorgan-IOHK removed this from Closed in Adrestia Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotr-iohk piotr-iohk

Labels
Bug PRIORITY:HIGH Require immediate attention. SEVERITY:LOW Small defects which does not prevent any crucial functionality to work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvl @KtorZ @piotr-iohk