Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please increase the maxLength of the AssetTicker field #2541

Closed
gitmachtl opened this issue Feb 26, 2021 · 4 comments
Closed

Please increase the maxLength of the AssetTicker field #2541

gitmachtl opened this issue Feb 26, 2021 · 4 comments

Comments

@gitmachtl
Copy link

This is linked to

https://github.com/input-output-hk/metadata-server/issues/30

please move it into the right place.


Hi,

https://github.com/input-output-hk/metadata-server/blob/master/specifications/wallet/submission-schema.json

specifies a maxLength of only 4 chars for the ticker field of the native token.

please increase this to 8 chars!

why is there such a short limitation needed or suggested? so not even pool-operators can use there native pool tickers to create there own native assets with the same ticker name!?

please explain this to us or please provide us the right contact to discuss this, because is this is not a rational decision imo.

thank you very much!

Martin

@rvl
Copy link
Contributor

rvl commented Feb 27, 2021

Hi @gitmachtl, you don't need to use the ticker field - it's an optional abbreviation of the asset name. When ticker, is not present, user interfaces will display name instead. If the name is long, however, the GUI may need to truncate it to fit in the space.

@rvl
Copy link
Contributor

rvl commented Feb 27, 2021

We could probably increase the ticker max length to 5 so it matches the stake pool ticker. Longer than this, it starts looking less like an abbreviation, and more like a name.

@gitmachtl
Copy link
Author

gitmachtl commented Feb 27, 2021

Ok, than please increase it to 5 chars. So we have it set up the same way like a pool ticker. You have 5 chars for pool tickers and a longer Name. So this would be consistent.

Short tickers can be confusing:
GPWR -> GREENPWR, GPWR -> GREATPWR, PWRL -> POWERLESS
BTC, BCH, BSV, BTG, etc... are all very confusing and are all "Bitcoin".

gitmachtl added a commit to gitmachtl/metadata-server that referenced this issue Mar 1, 2021
cardano-foundation/cardano-wallet#2541 (comment)

Update for the maxLength of the Coin/Asset Ticker to be consistent with the Pool Ticker Format (minLength could be raised to from 2 to 3 chars)
@rvl
Copy link
Contributor

rvl commented Mar 30, 2021

This was resolved in v2021-03-04

@rvl rvl closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants