Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests on Jörmungandr #358

Closed
3 tasks done
KtorZ opened this issue Jun 4, 2019 · 1 comment
Closed
3 tasks done

Integration tests on Jörmungandr #358

KtorZ opened this issue Jun 4, 2019 · 1 comment
Assignees

Comments

@KtorZ
Copy link
Member

KtorZ commented Jun 4, 2019

Context

Our integration test scenarios (see Test/Integration/Scenario) describe interactions with the API or CLI and expectations from these interactions. In practice, most of these scenarios are backend-agnostic and, we should be able to replay most of them for either cardano-http-bridge or jörmungandr.

PR #334 already makes a first step in that direction by moving the Network environment and backend-specific bits up-to the integration main file, leaving the scenarios really just about the interactions with the API or CLI.

Decision

  • Move the integration framework (DSL & Request) from the http-bridge module to core.
  • Set up integration tests in jörmungandr and replay all scenarios using jörmungandr as a backend target (while still playing all the scenarios for the bridge).
  • We'll probably need to adapt the Faucet module as well although a similar approach should be possible with Jörmungandr too.

Acceptance Criteria

  1. Integration tests scenarios must still run for the http-bridge
  2. Integration tests scenarios must run for jörmungandr
  3. Some scenarios that are too backend-specific may be disabled and/or duplicated for their corresponding backend.

Development Plan

  • I intend to extend the move DSL and Request to the core in order to reuse them both at http-bridge and jormungandr
  • I intend to deliver faucet scaffolding for jormungandr that will work with small amount of work when tx API is finalized
  • I intend to make integration tests scenarios passing with jörmungandr

PR

Number Base
#396 master
#424 master
#454 master
#470 master
#471 master
#473 master
#475 master
#496 master
#504 master
#506 master
#509 master

QA

@piotr-iohk
Copy link
Contributor

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants