Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary integration tests cleanup before turning on remaining ones on Jörmungandr #504

Merged
merged 4 commits into from
Jul 4, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jul 4, 2019

Issue Number

#358

Overview

  • I have moved mock-daedalus.js in a shared location, and shared it between
  • I have split "version" and "help" scenarios from Mnemonics into Miscellaneous
  • I have renamed the Cardano/LauncherSpec for consistency with other scenarios.

Comments

KtorZ added 4 commits July 4, 2019 10:10
So that it can be run for both Jörmungandr executable and http-bridge
- Create a Miscellaneous module to carry --help and version scenarios (instead of having this in Mnemonics)
- Rename 'Cardano/LauncherSpecs' to 'Test/Integration/HttpBridge/Scenario/CLI/Launcher.hs'
@KtorZ KtorZ self-assigned this Jul 4, 2019
@KtorZ KtorZ requested a review from piotr-iohk July 4, 2019 08:20
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@KtorZ KtorZ merged commit 8992b6d into master Jul 4, 2019
@KtorZ KtorZ deleted the KtorZ/preliminary-cleanup-integration-tests branch July 4, 2019 09:10
@KtorZ KtorZ restored the KtorZ/preliminary-cleanup-integration-tests branch July 4, 2019 09:10
@KtorZ KtorZ deleted the KtorZ/preliminary-cleanup-integration-tests branch July 4, 2019 16:15
@KtorZ KtorZ mentioned this pull request Jul 4, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants