Providing -- --config node_config.yaml on launch makes wallet exit ugly #848
Assignees
Comments
piotr-iohk
changed the title
This was referenced Oct 17, 2019
iohk-bors bot
added a commit
that referenced
this issue
Oct 21, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 21, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=rvl a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. 864: nix: Provide derivations for Daedalus installer r=KtorZ a=rvl Relates to #863. Based on #828. # Overview - @disassembler @cleverca22 It's not exactly the same as before but should work ok I think. - Adds source filtering to avoid unnecessary rebuilds. # Comments To build: ``` nix-build -A cardano-wallet-jormungandr nix-build release.nix -A daedalus-jormungandr.windows -o daedalus-jormungandr-windows nix-build release.nix -A daedalus-jormungandr.macos -o daedalus-jormungandr-macos nix-build release.nix -A daedalus-jormungandr.linux -o daedalus-jormungandr-linux ``` Note that `daedalus-jormungandr.{windows,macos,linux}` from `release.nix` reference the same `cardano-wallet-jormungandr` derivation, only with different `system` or `crossSystem` arguments. So Daedalus may also import from `default.nix` rather than `release.nix`. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. 864: nix: Provide derivations for Daedalus installer r=KtorZ a=rvl Relates to #863. Based on #828. # Overview - @disassembler @cleverca22 It's not exactly the same as before but should work ok I think. - Adds source filtering to avoid unnecessary rebuilds. # Comments To build: ``` nix-build -A cardano-wallet-jormungandr nix-build release.nix -A daedalus-jormungandr.windows -o daedalus-jormungandr-windows nix-build release.nix -A daedalus-jormungandr.macos -o daedalus-jormungandr-macos nix-build release.nix -A daedalus-jormungandr.linux -o daedalus-jormungandr-linux ``` Note that `daedalus-jormungandr.{windows,macos,linux}` from `release.nix` reference the same `cardano-wallet-jormungandr` derivation, only with different `system` or `crossSystem` arguments. So Daedalus may also import from `default.nix` rather than `release.nix`. 878: Support for legacy UTxO witness in Jörmungandr r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have extended `mkStdTx` so that it would properly handle transactions coming from a `RndKey` and construct `legacy-utxo` witnesses for it. # Comments <!-- Additional comments or screenshots to attach if any --> Jörmungandr doesn't implement creating legacy utxo witnesses from jcli ... [jcli/src/jcli_app/transaction/mk_witness.rs](https://github.com/input-output-hk/jormungandr/blob/master/jcli/src/jcli_app/transaction/mk_witness.rs#L78-L82) ```rust WitnessType::OldUTxO => { // TODO unimplemented!() let _secret_key: SecretKey<Ed25519Bip32> = self.secret()?; Err(Error::MakeWitnessLegacyUtxoUnsupported)?; unimplemented!() } ``` so I had to construct them by hand according to: - The format defined in [chain-impl-mockchain#witnesses](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/doc/format.md#witnesses) - The format from the source (double checking it matches the doc..) [chain-impl-mockchain/src/transaction/witness.rs](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/src/transaction/witness.rs#L173-L176) It'd be nice to review our golden if / when the constructor for the witness type gets updated. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 879: Porting the rest of forget pending tx integration tests to CLI r=KtorZ a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #836 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have ported the rest of forgetting pending tx integration tests to CLI # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. 864: nix: Provide derivations for Daedalus installer r=KtorZ a=rvl Relates to #863. Based on #828. # Overview - @disassembler @cleverca22 It's not exactly the same as before but should work ok I think. - Adds source filtering to avoid unnecessary rebuilds. # Comments To build: ``` nix-build -A cardano-wallet-jormungandr nix-build release.nix -A daedalus-jormungandr.windows -o daedalus-jormungandr-windows nix-build release.nix -A daedalus-jormungandr.macos -o daedalus-jormungandr-macos nix-build release.nix -A daedalus-jormungandr.linux -o daedalus-jormungandr-linux ``` Note that `daedalus-jormungandr.{windows,macos,linux}` from `release.nix` reference the same `cardano-wallet-jormungandr` derivation, only with different `system` or `crossSystem` arguments. So Daedalus may also import from `default.nix` rather than `release.nix`. 878: Support for legacy UTxO witness in Jörmungandr r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have extended `mkStdTx` so that it would properly handle transactions coming from a `RndKey` and construct `legacy-utxo` witnesses for it. # Comments <!-- Additional comments or screenshots to attach if any --> Jörmungandr doesn't implement creating legacy utxo witnesses from jcli ... [jcli/src/jcli_app/transaction/mk_witness.rs](https://github.com/input-output-hk/jormungandr/blob/master/jcli/src/jcli_app/transaction/mk_witness.rs#L78-L82) ```rust WitnessType::OldUTxO => { // TODO unimplemented!() let _secret_key: SecretKey<Ed25519Bip32> = self.secret()?; Err(Error::MakeWitnessLegacyUtxoUnsupported)?; unimplemented!() } ``` so I had to construct them by hand according to: - The format defined in [chain-impl-mockchain#witnesses](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/doc/format.md#witnesses) - The format from the source (double checking it matches the doc..) [chain-impl-mockchain/src/transaction/witness.rs](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/src/transaction/witness.rs#L173-L176) It'd be nice to review our golden if / when the constructor for the witness type gets updated. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 879: Porting the rest of forget pending tx integration tests to CLI r=KtorZ a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #836 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have ported the rest of forgetting pending tx integration tests to CLI # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. 864: nix: Provide derivations for Daedalus installer r=KtorZ a=rvl Relates to #863. Based on #828. # Overview - @disassembler @cleverca22 It's not exactly the same as before but should work ok I think. - Adds source filtering to avoid unnecessary rebuilds. # Comments To build: ``` nix-build -A cardano-wallet-jormungandr nix-build release.nix -A daedalus-jormungandr.windows -o daedalus-jormungandr-windows nix-build release.nix -A daedalus-jormungandr.macos -o daedalus-jormungandr-macos nix-build release.nix -A daedalus-jormungandr.linux -o daedalus-jormungandr-linux ``` Note that `daedalus-jormungandr.{windows,macos,linux}` from `release.nix` reference the same `cardano-wallet-jormungandr` derivation, only with different `system` or `crossSystem` arguments. So Daedalus may also import from `default.nix` rather than `release.nix`. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 22, 2019
862: jormungandr launch: use --rest-listen instead of generating config.yaml r=KtorZ a=rvl Relates to #832 and #848. Supersedes #850. # Overview `cardano-wallet-jormungandr launch` specifies the REST API port and storage directory. The user provides the rest of the Jörmungandr configuration (e.g. trusted peers). # Comments The Jörmungandr P2P listen address, port, and log level are no longer configured by cardano-wallet. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Oct 23, 2019
880: Jormungandr 0.7.0 r=KtorZ a=piotr-iohk
# Issue Number
# Overview
<!-- Detail in a few bullet points the work accomplished in this PR -->
- [ ] ~Jormungandr 0.7.0-alpha.dev~
- [ ] Jormungandr 0.7.0-alpha.dev.1
# Comments
It works fine with `jormungandr + cardano-wallet-jormungandr serve` but doesn't work with launch...
```
$cardano-wallet-jormungandr launch --genesis-block block0.bin -- --secret secret.yaml
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Using directory: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Using directory: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/wallets
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Running as v2019.10.16
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Wallet backend server starting...
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Node is Jörmungandr on testnet
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Generated Jörmungandr's configuration to: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/jormungandr-config.yaml
[iohk.cardano-wallet:Notice:ThreadId 4] [2019-10-22 09:55:55.39 UTC] Starting process jormungandr
--genesis-block block0.bin
--config /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/jormungandr-config.yaml
--log-level info
--secret secret.yaml
[iohk.cardano-wallet.jormungandr.14208:Info:ThreadId 4] [2019-10-22 09:55:55.39 UTC] Process jormungandr started with pid 14208
Oct 22 11:55:55.396 INFO Starting jormungandr 0.7.0-alpha.dev (HEAD-61fa897, release, linux [x86_64]) - [rustc 1.38.0 (625451e37 2019-09-23)], task: init
Oct 22 11:55:55.396 INFO Starting 1 workers, scope: global
Oct 22 11:55:55.396 INFO Starting server on 127.0.0.1:33671, scope: global
Oct 22 11:55:55.397 INFO storing blockchain in '"/home/piotr/.local/share/cardano-wallet/jormungandr/testnet/chain/blocks.sqlite"', task: init
Oct 22 11:55:55.406 ERRO Error occurred during request handling, status: 503 Service Unavailable Full REST context not available yet, scope: global
cardano-wallet-jormungandr: ErrUnexpectedNetworkFailure (Link {_segments = ["api","v0","block","4c05c5bb1dfa2848a2a36249b28d97ef8e6c77c7cb1f9626d1c4024c2470a2c2"], _queryParams = []}) (FailureResponse (Response {responseStatusCode = Status {statusCode = 503, statusMessage = "Service Unavailable"}, responseHeaders = fromList [("content-length","0"),("date","Tue, 22 Oct 2019 09:55:55 GMT")], responseHttpVersion = HTTP/1.1, responseBody = ""}))
```
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl
Relates to #848.
# Overview
Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862.
Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 23, 2019
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 23, 2019
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 23, 2019
881: Connect Pool DB with Api r=KtorZ a=Anviking # Issue Number #713 # Overview - [x] I have implemented a `GET /stake-pool` that reads and combines metrics from `Pool.DB` - [x] TODO: Figure out when we are unsynced - [ ] TODO: Look for things to test if possible in this PR # Comments ### Self-node with a very short epoch-length (results are unavailable across epoch boundaries)  ### Testnet syncing which is interrupted and resumed  <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 884: More integration tests for Byron wallets r=KtorZ a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] More integration tests for Byron wallets ensuring that Shelley endpoints/CLI cannot manage them # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Oct 23, 2019
884: More integration tests for Byron wallets r=KtorZ a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] More integration tests for Byron wallets ensuring that Shelley endpoints/CLI cannot manage them # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
|
how are we with this one? |
|
no longer applies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
One can now do:
cardano-wallet-jormungandr launch --genesis-block-hash <hash> -- --config node_config.yamlAs a result underlying
jormungandrfails causelaunchprovides two--configs to it. The error message is not quite human firendly.cardano-wallet-jormungandrshould exit with error message explaining that--configis generated automatically and one cannot provide--configinlaunchSteps to Reproduce
Expected behavior
Friendly error message:
Actual behavior
Long unfriendly error:
Resolution Plan
PR
developQA
The text was updated successfully, but these errors were encountered: