Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servant API: Post Wallet Operation #119

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Servant API: Post Wallet Operation #119

merged 2 commits into from
Mar 26, 2019

Conversation

jonathanknowles
Copy link
Member

Issue Number

Issue #118 (Servant API: add postWallet and putWallet operations)

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-post-put-wallet branch from 3043dc1 to ce91a1c Compare March 25, 2019 06:17
@jonathanknowles jonathanknowles mentioned this pull request Mar 25, 2019
Closed
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-post-put-wallet branch from 1bf9c33 to 5f606ac Compare March 25, 2019 08:20
@jonathanknowles jonathanknowles self-assigned this Mar 25, 2019
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-post-put-wallet branch 3 times, most recently from 08a9bd9 to 37eb940 Compare March 26, 2019 04:32
@KtorZ KtorZ changed the title [WIP] Servant API: add postWallet and putWallet operations Servant API: Post Wallet Operation Mar 26, 2019
@KtorZ KtorZ force-pushed the jonathanknowles/add-post-put-wallet branch from 37eb940 to 956214b Compare March 26, 2019 16:26
@KtorZ KtorZ marked this pull request as ready for review March 26, 2019 16:26
@KtorZ KtorZ self-requested a review March 26, 2019 16:26
jonathanknowles and others added 2 commits March 26, 2019 17:30
@jonathanknowles @KtorZ
Finalize API types definitions for preliminary types
5fff55b 
This includes:

- `GET /wallets`
- `POST /wallets`
- `GET /wallets/{walletId}`
- `DELETE /wallets/{walletId}`

Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@KtorZ
regenerate golden tests for API types
c1d678e
@KtorZ KtorZ force-pushed the jonathanknowles/add-post-put-wallet branch from 956214b to c1d678e Compare March 26, 2019 16:30
KtorZ
KtorZ approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapped up 👍

@jonathanknowles jonathanknowles mentioned this pull request Mar 26, 2019
Closed
3 tasks
@KtorZ KtorZ merged commit 3c56a9c into master Mar 26, 2019
@KtorZ KtorZ deleted the jonathanknowles/add-post-put-wallet branch March 26, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanknowles @KtorZ