Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few negative test cases to ApiTypes specs for JSON instances that aren't fully generic #128

Merged
merged 6 commits into from
Mar 27, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Mar 27, 2019

Issue Number

#53

Overview

  • Added more negative test cases in Api Types

Comments

Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

KtorZ and others added 6 commits March 27, 2019 19:58
The rational is that, doing slotting arithmetic forces us to keep track of the 'slotsPerEpoch'
which is in practice, rather tricky. We can _probably_ get away by leveraging the _chained_
aspect of the blockchain (that each block points to its previous one) and rewind the chain
when needed.
@KtorZ KtorZ force-pushed the KtorZ/53/test-case-negative-paths branch from e0a84aa to c7b85b6 Compare March 27, 2019 18:59
@KtorZ KtorZ merged commit 026f285 into master Mar 27, 2019
@KtorZ KtorZ deleted the KtorZ/53/test-case-negative-paths branch March 27, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants