Make stake pools engine rollback faster. #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rolling back, we currently only log monitoring restarts, which can be somewhat confusing when done several times in a row: [pools-engine] Monitoring stake pools. Currently at f4260343-[1158372.5#220] [pools-engine] Monitoring stake pools. Currently at 20bd31a4-[1158372.1#216] [pools-engine] Monitoring stake pools. Currently at 437a7400-[1158371.6#212] [pools-engine] Monitoring stake pools. Currently at 5c874264-[1158371.2#208] Although this is typical of rollbacks, it's better to mention it explicitely to better track what the system is doing.
KtorZ
changed the title
|
bors try |
tryBuild succeeded |
| @@ -175,7 +177,7 @@ monitorStakePools tr nl db@DBLayer{..} = do | |||
| readPoolRegistration poolId >>= \case | |||
| Nothing -> putPoolRegistration sl0 r | |||
| Just{} -> pure () | |||
| readPoolProductionCursor k | |||
| readPoolProductionCursor (max 100 k) | |||
There was a problem hiding this comment.
ah, ok. explained below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1281
Overview
fe138cc
Log roll back attempts in pools monitoring
When rolling back, we currently only log monitoring restarts, which
can be somewhat confusing when done several times in a row:
[pools-engine] Monitoring stake pools. Currently at f4260343-[1158372.5#220]
[pools-engine] Monitoring stake pools. Currently at 20bd31a4-[1158372.1#216]
[pools-engine] Monitoring stake pools. Currently at 437a7400-[1158371.6#212]
[pools-engine] Monitoring stake pools. Currently at 5c874264-[1158371.2#208]
Although this is typical of rollbacks, it's better to mention it
explicitely to better track what the system is doing.
76bf85a
increase network layer observation window's length
Comments
See details in #1281