http bridge with local cluster in integration tests #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the MVar wrapper around the Context - Make API of the Request module more orthogonal - Remove 'Scenario' plumbing and pass context explicity through HSpec 'SpecWith' mechanism
piotr-iohk
reviewed
Mar 28, 2019
| , "--template", network | ||
| ] (threadDelay 5000000) | ||
|
|
||
| cardanoWalletServer serverPort bridgePort network = Command |
There was a problem hiding this comment.
Why not cardanoWalletLauncher instead Bridge and Server?
There was a problem hiding this comment.
Good point 😶 ... I have no answers.
|
Merging this to get the |
piotr-iohk
pushed a commit
that referenced
this pull request
Mar 29, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#67
Overview
test/data/cardano-node-simplethat would do the trick).Comments
We do nothing with the cluster (for now) but it should be fully functional and allow us to submit transactions and see them being accepted by nodes.
@piotr-iohk This will conflict with #131 but I am happy to adapt either of the PR with the change. Conceptually, it doesn't really interfere with your addition on #131.