Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get 'cardano-node-simple' available in CI & allow manipulating stream output when launching commands #135

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Mar 29, 2019

Issue Number

#67

Overview

  • I have fixed the CI scripts so that 'cardano-node-simple' is now available in $PATH for integration tests
  • I have used the 'cardano-wallet-launcher' alongside the cluster (rather than spawning a bridge and a wallet separately).
  • I allowed redirecting stdout and stderr when launching commands (to avoid being completely bloated by the 'cardano-node-simple' logs that are already redirected to /tmp/cardano-node-simple/logs anyway.

Comments

@KtorZ KtorZ self-assigned this Mar 29, 2019
@KtorZ KtorZ requested a review from piotr-iohk March 29, 2019 08:55
.travis.yml Outdated
@@ -63,6 +63,9 @@ jobs:
name: "Compiling"
script:
- mkdir -p ~/.local/bin
- travis_retry curl -L -o cardano-node-simple-3.0.1.tar.gz https://raw.githubusercontent.com/input-output-hk/cardano-wallet/master/test/data/cardano-node-simple/cardano-node-simple-3.0.1.tar.gz
- tar xzf cardano-node-simple-3.0.1.tar.gz -C $HOME/.local/bin
- cardano-node-simple --help
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this extra one on rebase after #131 is merged, this is mainly for testing and checking that things works well in CI.

@KtorZ
Copy link
Member Author

KtorZ commented Mar 29, 2019

Ho dear, librocksdb strikes again.

Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@KtorZ KtorZ force-pushed the KtorZ/67/local-cluster-part2 branch 5 times, most recently from 791e8aa to ba81d1e Compare March 29, 2019 13:14
@KtorZ KtorZ force-pushed the KtorZ/67/local-cluster-part2 branch from ba81d1e to eb79a14 Compare March 29, 2019 13:29
@KtorZ KtorZ merged commit 8164411 into master Mar 29, 2019
@KtorZ KtorZ deleted the KtorZ/67/local-cluster-part2 branch March 29, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants