Fix slot depth unit to 'slot'. Add block type #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akegalj
commented
Apr 1, 2019
specifications/api/swagger.yaml
Outdated
| @@ -35,12 +35,27 @@ numberOfSlots: &numberOfSlots | |||
| properties: | |||
| quantity: | |||
| type: integer | |||
| minimum: 0 | |||
| minimum: 1337 | |||
There was a problem hiding this comment.
a bit more "arbitrary" number
There was a problem hiding this comment.
Hmm... But this is wrong here, it states that the minimum should be 1337 😶
Did you mean to add it as example ?
akegalj
commented
Apr 1, 2019
| unit: | ||
| type: string | ||
| enum: | ||
| - slot | ||
| example: 1337 | ||
| example: "slot" |
There was a problem hiding this comment.
we already discussed over slack that old slot unit was probably a mistake
akegalj
commented
Apr 1, 2019
8 tasks
KtorZ
reviewed
Apr 2, 2019
akegalj
force-pushed
the
akegalj/93/improve_return_type
branch
from
6a0871e
to
eb908bb
Compare
KtorZ
approved these changes
Apr 2, 2019
KtorZ
force-pushed
the
akegalj/93/improve_return_type
branch
from
bd3862b
to
e313170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#93
Overview
Comments
This adds slight modification to our
swagger.jsonto make types more strict. It might be overkill though