Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ApiT SignedTx) roundtrip & goldens #141

Merged
merged 1 commit into from
Apr 2, 2019
Merged

(ApiT SignedTx) roundtrip & goldens #141

merged 1 commit into from
Apr 2, 2019

Conversation

Anviking
Copy link
Collaborator

@Anviking Anviking commented Apr 2, 2019 •
edited
Loading

Issue Number

#89

Overview

  • I have added roundtrip & goldens for (ApiT SignedTx)

Comments

  • We didn't have any tests for HttpBridge Api-types, so had to create some scaffolding

@Anviking Anviking force-pushed the anviking/89/test-signed-tx-json branch from 332b052 to 4ca3ebb Compare April 2, 2019 13:37
@Anviking Anviking requested a review from KtorZ April 2, 2019 13:37
@Anviking Anviking self-assigned this Apr 2, 2019
@piotr-iohk piotr-iohk mentioned this pull request Apr 2, 2019
Closed
5 tasks
paweljakubas
paweljakubas approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KtorZ KtorZ merged commit 8851095 into master Apr 2, 2019
@KtorZ KtorZ deleted the anviking/89/test-signed-tx-json branch April 2, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anviking @KtorZ @paweljakubas