Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DaedalusIPC #1424

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Remove DaedalusIPC #1424

merged 1 commit into from
Apr 1, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 10, 2020

Issue Number

Relates to ADP-92.

Overview

The new cardano-launcher code pre-allocates TCP ports for the jormungandr backend, uses unix sockets/named pipes for the byron backend, and has a simpler method of ensuring clean shutdown of the cardano-wallet server on Windows (#1314).

Comments

Can be merged once cardano-launcher integration into Daedalus is complete.

@rvl rvl self-assigned this Mar 10, 2020
@rvl rvl force-pushed the rvl/adp-92/remove-daedalus-ipc branch from 17b5b89 to 1eec93d Compare March 24, 2020 08:30
@rvl
Copy link
Contributor Author

rvl commented Mar 24, 2020

Rebased

@rvl rvl force-pushed the rvl/adp-92/remove-daedalus-ipc branch 2 times, most recently from 8cf7595 to 9fbbc97 Compare April 1, 2020 07:41
@rvl
Copy link
Contributor Author

rvl commented Apr 1, 2020

The cardano-launcher changes are now merged into the Daedalus develop branch, so this PR is ready for merge.

@rvl rvl marked this pull request as ready for review April 1, 2020 07:42
@KtorZ KtorZ self-requested a review April 1, 2020 08:00
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvl rvl force-pushed the rvl/adp-92/remove-daedalus-ipc branch from fc2bd15 to e66916e Compare April 1, 2020 12:10
The new cardano-launcher code pre-allocates TCP ports for the
jormungandr backend, uses unix sockets/named pipes for the byron
backend, and has a simpler method of ensuring clean shutdown of the
cardano-wallet server on Windows.

https://github.com/input-output-hk/cardano-launcher
@rvl rvl force-pushed the rvl/adp-92/remove-daedalus-ipc branch from e66916e to fb4f325 Compare April 1, 2020 13:40
@rvl
Copy link
Contributor Author

rvl commented Apr 1, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 1, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 91b610e into master Apr 1, 2020
@iohk-bors iohk-bors bot deleted the rvl/adp-92/remove-daedalus-ipc branch April 1, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants