Implement 'cardano-wallet server' command to spin up an actual server #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
piotr-iohk
suggested changes
Apr 4, 2019
There was a problem hiding this comment.
lgtm (I suppose :))
However currently cardano-wallet-launcher does not spin up (i.e. doing stack exec -- cardano-wallet-launcher does not start cardano-wallet server).
Not sure if this is a bug in docopt, but when I switched places of --port and --network it worked fine (https://github.com/input-output-hk/cardano-wallet/blob/master/app/launcher/Main.hs#L102-L107)
|
@piotr-iohk So it's apparently a known issue from the docopt Haskell implementation (cf: https://github.com/docopt/docopt.hs#differences-from-reference-python-implementation) ... *sigh* 😞 We may fix upstream eventually, but for now, I've fixed the argument position and added a disclaimer in the CLI definition. |
piotr-iohk
approved these changes
Apr 5, 2019
|
lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#96
Overview
cardano-wallet servercommand to serve our API handlers*HttpApiinstances required by Servant on a few path & query paramsComments
Still a bit "rough", but does the job.