Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet Id Calculation #156

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Wallet Id Calculation #156

merged 2 commits into from
Apr 5, 2019

Commits on Apr 5, 2019

  1. replace WalletId internal 'UUID' with a 'Digest Blake2b_160' 

    We needed a way to compute wallet ids in a deterministic manner, without taking the risk of exposing
the root private key. Since the mnemonic (and therefore, the root key) is the only real common piece
of information between two wallets, we got to derive _something_ from it in a deterministic manner.

The original idea was to derive a number / seed that would seed a UUID random generator, though, we
can also just stop the process at the seed (no need for the extra step of computing a uuid). Ids are
therefore just a hex-encoded hash of the public key. MD5 would have been sufficient, but going for
Blake2b 160 because... [insert valid reason here]
    @KtorZ
    KtorZ committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    98cb85d View commit details
    Browse the repository at this point in the history

  2. check for determinism and injectiveness of wallet ids

    @KtorZ
    KtorZ committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    788356c View commit details
    Browse the repository at this point in the history