Add roundtrip textual encoding tests for Network and Port CLI types.
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Good idea. |
rvl
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Looks fine to me.
One way of separating the wallet and CLI "domains" is by using module names, which is what has been done here.
Another way would be to use cabal internal libraries - these are incompatible with weeder, but .weeder.yaml shows that it's already not working very well.
KtorZ
force-pushed
the
jonathanknowles/text-instances
branch
from
368116a
to
c8dbd8e
Compare
KtorZ
force-pushed
the
jonathanknowles/text-instances
branch
from
c8dbd8e
to
0d45704
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Issue #96
Overview
Add roundtrip textual encoding tests for
NetworkandPortCLI types.