Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold WalletLayer for tx creation #164

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Scaffold WalletLayer for tx creation #164

merged 3 commits into from
Apr 9, 2019

Conversation

Anviking
Copy link
Collaborator

@Anviking Anviking commented Apr 8, 2019

Issue Number

#95

Overview

  • Some preparatory work in their own commit (Move TxWitness,
    Add Binary.toByteString helper)
  • I have added createUnsignedTx , signTx , and submitTx
  • I have added added new errors and tweaked naming of existing ones

Comments

@Anviking Anviking self-assigned this Apr 8, 2019
Anviking
Anviking commented Apr 8, 2019
View reviewed changes
src/Cardano/Wallet.hs Outdated Show resolved Hide resolved
KtorZ
KtorZ reviewed Apr 8, 2019
View reviewed changes
src/Cardano/Wallet.hs Show resolved Hide resolved
src/Cardano/Wallet.hs Outdated Show resolved Hide resolved
src/Cardano/Wallet.hs Outdated Show resolved Hide resolved
rvl
rvl approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

src/Cardano/Wallet.hs Outdated Show resolved Hide resolved
@KtorZ KtorZ force-pushed the anviking/95/extend-walletlayer branch from c6a5f5d to e0d0e08 Compare April 9, 2019 14:26
KtorZ
KtorZ approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 rebased on top of master + applied changes as discussed.

@KtorZ KtorZ merged commit 640abe6 into master Apr 9, 2019
@KtorZ KtorZ deleted the anviking/95/extend-walletlayer branch April 9, 2019 14:49
@KtorZ KtorZ mentioned this pull request Apr 10, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@KtorZ KtorZ KtorZ approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anviking @rvl @KtorZ