Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin Selection Split Fee Module #174

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Apr 23, 2019

Issue Number

#92

Overview

  • I have split logic related to fee calculation into its own module
  • I have placed fee policies into a more specific namespace 'CoinSelection.Policy'

Comments

You suggested this initially @paweljakubas and I thought fee logic would be better off being part of the CoinSelection. Yet, the implementation is actually rather complex, and the test structure had become quite confusing and entangled. So I just renamed a few modules and extracted the bits related to the fee adjustment into its own module.

@KtorZ KtorZ requested a review from paweljakubas April 23, 2019 13:06
@KtorZ KtorZ self-assigned this Apr 23, 2019
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very needed code reshuffling as coin selection/fee grown to a substantial level

@KtorZ KtorZ merged commit 7aaf94f into master Apr 23, 2019
@KtorZ KtorZ deleted the KtorZ/coin-selection-split-fee branch April 23, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants