Implement some missing API handlers for the wallets endpoints #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
reviewed
Apr 25, 2019
| @@ -353,6 +386,22 @@ prop_createWalletTwice (key@(PrimaryKey wid), cp, meta) = | |||
| runExceptT (createWallet db key cp meta) `shouldReturn` Right () | |||
| runExceptT (createWallet db key cp meta) `shouldReturn` Left err | |||
|
|
|||
| -- | Trying to create a same wallet twice should yield an error | |||
There was a problem hiding this comment.
I suppose should be Trying to remove the same wallet twice...
There was a problem hiding this comment.
Indeed 👍 , wrong copy-pasting 😬
There was a problem hiding this comment.
BTW. Perhaps the case create wallet twice could be added here also? Or maybe it is not handled on the DB layer (I mean the fact the same wallet cannot be created multiple times)?
There was a problem hiding this comment.
oh wait, it's already there :)
|
@piotr-iohk Merging this, I've fixed the typo in a next incoming PR 👍 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#96
Overview
Comments