Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keystore In Database #181

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Keystore In Database #181

merged 2 commits into from
Apr 26, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Apr 25, 2019

Issue Number

#95

Overview

  • I have stored the root private key (and the hash of the corresponding encryption passphrase) in the DB
  • I have extended the DB layer to provide an accessor to read that key + hash back later

Comments

@KtorZ KtorZ requested a review from Anviking April 25, 2019 10:26
@KtorZ KtorZ self-assigned this Apr 25, 2019
@@ -38,6 +40,7 @@ data DBLayer m s = DBLayer
:: PrimaryKey WalletId
-> Wallet s
-> WalletMetadata
-> (Key 'RootK XPrv, Hash "encryption")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-> (Key 'RootK XPrv, Hash "encryption")
-> (Key 'RootK XPrv, Passphrase "encryption")

@@ -38,6 +40,7 @@ data DBLayer m s = DBLayer
:: PrimaryKey WalletId
-> Wallet s
-> WalletMetadata
-> (Key 'RootK XPrv, Hash "encryption")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-> (Key 'RootK XPrv, Hash "encryption")
-> (Key 'RootK XPrv, Passphrase "encryption")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind 🤦‍♂️

Copy link
Collaborator

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (rebasing off master)

@KtorZ KtorZ merged commit cbc5812 into master Apr 26, 2019
@KtorZ KtorZ deleted the KtorZ/95/keystore-in-db branch April 26, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants