Use haskell datatype names for swagger objects #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
akegalj
force-pushed
the
akegalj/93/standard-swagger-names
branch
from
9866e38
to
69742ff
Compare
KtorZ
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#93
Overview
ToSchemainstances to use standard haskell datatype names instead of renamedComments
Ideally manual
ToSchemainstances defined here https://github.com/input-output-hk/cardano-wallet/blob/akegalj/93/standard-swagger-names/test/unit/Cardano/Wallet/Api/TypesSpec.hs#L511 would be removed and they would be generated automatically (for example usingGenericwe could capture datatype name). Current approach doesn't add much overhead so I don't find this necessary.