Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added
the
RESOLVING ISSUE
|
I thought it was cardano-node that needed to have the fix, not us? The calculation happens on the "server-side" i.e. the node, so bumping the specs for the client (us) would be meaningless? |
|
You're probably right. It'll likely mess up with the whole build actually... because there would be two different versions in cardano-node and cardano-wallet. |
|
But we could probably fork the node from 1.14.2, fork cardano-ledger-specs from here https://github.com/input-output-hk/cardano-node/blob/1.14.2/stack.yaml#L62, cherry-pick in the fix, and target the resulting cardano-node from the wallet |
KtorZ
force-pushed
the
KtorZ/ledger-spec-fix-reward-ordering
branch
2 times, most recently
from
86aaebe
to
a5f7d49
Compare
Anviking
approved these changes
Jul 1, 2020
KtorZ
force-pushed
the
KtorZ/ledger-spec-fix-reward-ordering
branch
from
a5f7d49
to
b1b2967
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 2, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped cardano-ledger-specs to include a fix on non-myopic member reward ordering # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Canceled |
|
@KtorZ what about also to update matrix in README ? |
rvl
force-pushed
the
KtorZ/ledger-spec-fix-reward-ordering
branch
from
2c45e94
to
31a66d5
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 3, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped cardano-ledger-specs to include a fix on non-myopic member reward ordering # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
😢 😞 |
Build failed |
|
bors retry |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 3, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped cardano-ledger-specs to include a fix on non-myopic member reward ordering # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed |
KtorZ
force-pushed
the
KtorZ/ledger-spec-fix-reward-ordering
branch
from
6b0917a
to
02f6166
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 3, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 04b8141 📍 **Bump cardano-node to include a fix on non-myopic member reward ordering** - d064a2b 📍 **update compatibility matrix** - 67865c9 📍 **Also bump cardano-node in niv** Matches revision in snapshot.yaml. I can fix it later so that the cardano-node rev is defined in only one place, in the stack snapshot. - c571917 📍 **Unfortunately stack-to-nix does not support recursive snapshot URLs** - 02f6166 📍 **Regenerate nix** # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 3, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 04b8141 📍 **Bump cardano-node to include a fix on non-myopic member reward ordering** - d064a2b 📍 **update compatibility matrix** - 67865c9 📍 **Also bump cardano-node in niv** Matches revision in snapshot.yaml. I can fix it later so that the cardano-node rev is defined in only one place, in the stack snapshot. - c571917 📍 **Unfortunately stack-to-nix does not support recursive snapshot URLs** - 02f6166 📍 **Regenerate nix** # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 3, 2020
1841: Bump cardano-ledger-specs to include a fix on non-myopic member reward ordering r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 04b8141 📍 **Bump cardano-node to include a fix on non-myopic member reward ordering** - d064a2b 📍 **update compatibility matrix** - 67865c9 📍 **Also bump cardano-node in niv** Matches revision in snapshot.yaml. I can fix it later so that the cardano-node rev is defined in only one place, in the stack snapshot. - c571917 📍 **Unfortunately stack-to-nix does not support recursive snapshot URLs** - 02f6166 📍 **Regenerate nix** # Comments <!-- Additional comments or screenshots to attach if any --> As requested by Darko / Daedalus. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed |
Matches revision in snapshot.yaml. I can fix it later so that the cardano-node rev is defined in only one place, in the stack snapshot.
KtorZ
force-pushed
the
KtorZ/ledger-spec-fix-reward-ordering
branch
from
07efd81
to
148e370
Compare
|
bors try |
tryBuild failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
04b8141
📍 Bump cardano-node to include a fix on non-myopic member reward ordering
d064a2b
📍 update compatibility matrix
67865c9
📍 Also bump cardano-node in niv
Matches revision in snapshot.yaml.
I can fix it later so that the cardano-node rev is defined in only one
place, in the stack snapshot.
c571917
📍 Unfortunately stack-to-nix does not support recursive snapshot URLs
02f6166
📍 Regenerate nix
Comments
As requested by Darko / Daedalus.