Move sync progress logic to new module #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Jul 8, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2020
1875: Move sync progress logic to new module r=Anviking a=Anviking # Issue Number #1869 # Overview - [x] Make the sync progress logic easier to grasp by moving it to its own module - [x] Add a note about the calculation going to break in era-transitions # Comments - I believe we may have to have to provide _several_ methods of calculating the sync-progress. Maybe we need a different one for jormungandr. I think a new module is neat regardless. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Build failed |
We may need to implement multiple ways of calculating sync progress. Having it in its own module makes it easier to grasp.
I am however leaving some roundtrips in TypesSpec.
Anviking
force-pushed
the
anviking/1869/move-sync-progress
branch
from
24a1933
to
3ce848a
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2020
1875: Move sync progress logic to new module r=Anviking a=Anviking # Issue Number #1869 # Overview - [x] Make the sync progress logic easier to grasp by moving it to its own module - [x] Add a note about the calculation going to break in era-transitions # Comments - I believe we may have to have to provide _several_ methods of calculating the sync-progress. Maybe we need a different one for jormungandr. I think a new module is neat regardless. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl ### Overview HLint v3.1.6 can find more unused language extensions. ### Comments CI version update in PR #1857. Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1869
Overview
Comments