Getting minimum utxo #1894
Merged
Getting minimum utxo #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
added
the
ADDING FEATURE
|
bors try |
tryBuild succeeded |
KtorZ
reviewed
Jul 10, 2020
| let feePolicy@(LinearFee (Quantity a) _ _) = txp ^. #getFeePolicy | ||
| let feeOptions = (feeOpts tl Nothing feePolicy) | ||
| { dustThreshold = Coin $ ceiling a } | ||
| let minUtxo' = max (Coin $ ceiling a) minUtxo |
KtorZ
reviewed
Jul 10, 2020
| @@ -152,6 +152,7 @@ ProtocolParameters | |||
| protocolParametersTxMaxSize Word16 sql=tx_max_size | |||
| protocolParametersDecentralizationLevel Percentage sql=decentralization_level | |||
| protocolParametersDesiredNumberOfPools Word16 sql=desired_pool_number | |||
| protocolParametersMinimumUtxoValue W.Coin sql=minimum_utxo_value | |||
There was a problem hiding this comment.
We're going to need a migration for this one with a default value.
There was a problem hiding this comment.
cherry-picked one commit and also handled the migration in 487bb4f
KtorZ
reviewed
Jul 10, 2020
Turns out that adding column is a pretty common and straighfordward migration. I originally intended to add a new column to the TxMeta table, hence the refactor. In the end, I've used a different table for withdrawals, but the refactor is still worth it as it is IMO.
paweljakubas
force-pushed
the
paweljakubas/1893/getting-minimum-utxo
branch
from
487bb4f
to
ac66d37
Compare
adjust the rest of codebase
paweljakubas
force-pushed
the
paweljakubas/1893/getting-minimum-utxo
branch
from
ac66d37
to
193adf3
Compare
|
bors try |
KtorZ
approved these changes
Jul 10, 2020
tryBuild failed |
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1893
Overview
ProtocolParametersandApiNetworkParametersComments