Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ENV var export from buildkite script, to buildkite pipeline settings #190

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Apr 29, 2019

Issue Number

#100

Overview

  • I have moved ENV var export from buildkite script, to buildkite pipeline settings

Comments

See here. It seems that we can't modify the environment directly from the buildkite execution script, but it needs to be set within the platform interface through the "Pipeline Settings"; which I did. I've scheduled a new build for 10:30 to see whether this worked or not.

@KtorZ KtorZ self-assigned this Apr 29, 2019
@KtorZ KtorZ requested a review from piotr-iohk April 29, 2019 08:16
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess the whole script could be modified to use ENV variable then, but perhaps that's just neat-picking.

@KtorZ
Copy link
Member Author

KtorZ commented Apr 29, 2019

Well.. it seems it still doesn't work. There's some nix magic going on here I suppose :| ... I am not sure to understand what's happening. I'll investigate a bit more.

@KtorZ KtorZ force-pushed the KtorZ/buildkite-pipeline-ENV branch 8 times, most recently from 18ff098 to 18bb450 Compare April 29, 2019 10:30
@KtorZ KtorZ force-pushed the KtorZ/buildkite-pipeline-ENV branch from 18bb450 to 21081de Compare April 29, 2019 12:36
@KtorZ
Copy link
Member Author

KtorZ commented Apr 29, 2019

Finally nailed it and buildkite just finished successfully.

@KtorZ KtorZ merged commit 8a10276 into master Apr 29, 2019
@KtorZ KtorZ deleted the KtorZ/buildkite-pipeline-ENV branch April 29, 2019 13:39
alecalve pushed a commit to alecalve/cardano-sl that referenced this pull request May 16, 2019
4058: Support UtxoNotEnoughFragmented error r=KtorZ a=paweljakubas

Add multioutput integration tests

Fix Lens accesses and confusion between WalAddress vs WalletAddress vs V1 Address

## Description

This is backport of cardano-foundation/cardano-wallet#190

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants