Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack build #2056

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Fix stack build #2056

merged 2 commits into from
Aug 25, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 24, 2020

Overview

Bumps the cardano-ledger-specs package to latest master, which fixes a dangling symlink in its git repo which broke newer versions of stack.

Comments

Tested with:

stack build --fast --test --no-run-tests --bench --no-run-benchmarks

Bumps the cardano-ledger-specs package to latest master, which fixes a
dangling symlink in its git repo which broke newer versions of stack.
@rvl rvl self-assigned this Aug 24, 2020
@rvl
Copy link
Contributor Author

rvl commented Aug 24, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 24, 2020
2056: Fix stack build r=rvl a=rvl

### Overview

Bumps the cardano-ledger-specs package to latest master, which fixes a dangling symlink in its git repo which broke newer versions of stack.

### Comments

Tested with:

    stack build --fast --test --no-run-tests --bench --no-run-benchmarks


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2020

Build failed

Unit tests on linux have OOMed - probably memory leak or faulty shrinker.

    sequential puts replace values in order
      Checkpoint
        +++ OK, passed 100 tests (56% conflicting db entries).
      Wallet Metadata
        +++ OK, passed 100 tests (56% conflicting db entries).
      Tx History
        +++ OK, passed 100 tests (56% conflicting db entries).
      Private Key
        +++ OK, passed 100 tests (56% conflicting db entries).
    parallel puts replace values in _any_ order
      Checkpoint
        +++ OK, passed 10/nix/store/2w7m3lr8ldx8ipdll4j6fk4iid4irrck-stdenv-linux/setup: line 1303:    13 Killed                  /nix/store/gz1cbwbd4a5lvykbcm2z0irh1mldr8q1-cardano-wallet-core-test-unit-2020.8.3-x86_64-unknown-linux-musl/bin/unit
        14 Done                    | tee $out
builder for '/nix/store/wjkmhlj8f2l5bkiw0qswbh3qgrrakszh-cardano-wallet-core-test-unit-2020.8.3-x86_64-unknown-linux-musl-check-x86_64-unknown-linux-musl.drv' failed with exit code 137

@rvl
Copy link
Contributor Author

rvl commented Aug 24, 2020

bors retry

iohk-bors bot added a commit that referenced this pull request Aug 24, 2020
2056: Fix stack build r=rvl a=rvl

### Overview

Bumps the cardano-ledger-specs package to latest master, which fixes a dangling symlink in its git repo which broke newer versions of stack.

### Comments

Tested with:

    stack build --fast --test --no-run-tests --bench --no-run-benchmarks


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2020

Build failed

@hasufell
Copy link
Contributor

Bumps the cardano-ledger-specs package to latest master, which fixes a dangling symlink in its git repo which broke newer versions of stack.

Is there an upstream ticket about this?

@rvl
Copy link
Contributor Author

rvl commented Aug 24, 2020

No

@jonathanknowles
Copy link
Member

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit fece720 into master Aug 25, 2020
@iohk-bors iohk-bors bot deleted the rvl/fix-stack-build branch August 25, 2020 03:56
@rvl rvl linked an issue Aug 25, 2020 that may be closed by this pull request
@rvl rvl added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Aug 25, 2020
@hasufell
Copy link
Contributor

Interestingly, with this combination of commits you can't seem to build the ledger-spec tests:

[ 9 of 20] Compiling Test.Shelley.Spec.Ledger.ConcreteCryptoTypes ( src/Test/Shelley/Spec/Ledger/ConcreteCryptoTypes.hs, /home/jule/git/iohk/cardano-wallet/dist-newstyle/build/x86_64-linux/ghc-8.6.5/shelley-spec-ledger-test-0.1.0.0/build/Test/Shelley/Spec/Ledger/ConcreteCryptoTypes.o )

src/Test/Shelley/Spec/Ledger/ConcreteCryptoTypes.hs:15:29: error:
    Module ‘Cardano.Crypto.Hash’ does not export ‘MD5Prefix’
   |
15 | import Cardano.Crypto.Hash (MD5Prefix)

Via e.g. cabal build --enable-tests all.

@rvl
Copy link
Contributor Author

rvl commented Aug 28, 2020

@hasufell Yes, it needs a newer revision of cardano-base. The error was in cardano-node/cabal.project, which is our reference.

I'm not sure why you are running the tests of all dependencies, but fwiw PR #2088 will fix it.

@hasufell
Copy link
Contributor

I'm not sure why you are running the tests of all dependencies

Building, not running. This is more of a cabal oddity when passed --enable-tests. I think this will be gone in cabal-3.4.0.0, which doesn't treat source-repository packages as local anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build: Unsupported tarball from /tmp/with-repo-archive4121/foo.tar
3 participants