More measures post restoration benchmarks + SeqAnyState

[KtorZ]

Issue Number

#2032

Overview

• d820f36 make proportion more fine-grained to allow fractions of percent
• ce3f2a4 define a 'SeqAnyState' analogous to the 'RndAnyState' for benchmarks
• 02aba16 perform additional checks after restoration benchmarks
• 793de1c extend restoration benchmarks with a special 1% random wallet

Comments

On the testnet (although I messed up and the rnd % benchmark are actually doing 1%, 2% and 4% restorations!)

All results:
BenchResults:
  qualifier: Seq Empty Wallet
  restorationTime: 521.8 s
  listingAddressesTime: 15.90 ms
  estimatingFeesTime: 2.015 s
  utxoStatistics:
    = Total value of -0 lovelace across 0 UTxOs
     ... 10                0
     ... 100               0
     ... 1000              0
     ... 10000             0
     ... 100000            0
     ... 1000000           0
     ... 10000000          0
     ... 100000000         0
     ... 1000000000        0
     ... 10000000000       0
     ... 100000000000      0
     ... 1000000000000     0
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Rnd Empty Wallet
  restorationTime: 377.9 s
  listingAddressesTime: 989.2 μs
  estimatingFeesTime: 32.40 s
  utxoStatistics:
    = Total value of -0 lovelace across 0 UTxOs
     ... 10                0
     ... 100               0
     ... 1000              0
     ... 10000             0
     ... 100000            0
     ... 1000000           0
     ... 10000000          0
     ... 100000000         0
     ... 1000000000        0
     ... 10000000000       0
     ... 100000000000      0
     ... 1000000000000     0
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Rnd 0.1% Wallet
  restorationTime: 496.8 s
  listingAddressesTime: 72.31 ms
  estimatingFeesTime: 218.5 ms
  utxoStatistics:
    = Total value of 34915991397627 lovelace across 500 UTxOs
     ... 10                1
     ... 100               14
     ... 1000              1
     ... 10000             5
     ... 100000            36
     ... 1000000           16
     ... 10000000          12
     ... 100000000         28
     ... 1000000000        21
     ... 10000000000       138
     ... 100000000000      216
     ... 1000000000000     12
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Rnd 0.2% Wallet
  restorationTime: 698.7 s
  listingAddressesTime: 643.8 ms
  estimatingFeesTime: 317.9 ms
  utxoStatistics:
    = Total value of 80967721697473 lovelace across 921 UTxOs
     ... 10                1
     ... 100               20
     ... 1000              1
     ... 10000             9
     ... 100000            64
     ... 1000000           28
     ... 10000000          19
     ... 100000000         42
     ... 1000000000        38
     ... 10000000000       246
     ... 100000000000      426
     ... 1000000000000     26
     ... 10000000000000    1
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Rnd 0.4% Wallet
  restorationTime: 1016 s
  listingAddressesTime: 1.500 s
  estimatingFeesTime: 525.2 ms
  utxoStatistics:
    = Total value of 190005683160290 lovelace across 1894 UTxOs
     ... 10                2
     ... 100               45
     ... 1000              2
     ... 10000             12
     ... 100000            147
     ... 1000000           65
     ... 10000000          87
     ... 100000000         106
     ... 1000000000        93
     ... 10000000000       500
     ... 100000000000      772
     ... 1000000000000     59
     ... 10000000000000    3
     ... 100000000000000   1
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Seq 0.1% Wallet
  restorationTime: 458.2 s
  listingAddressesTime: 25.73 ms
  estimatingFeesTime: 27.27 ms
  utxoStatistics:
    = Total value of 2912204907552 lovelace across 38 UTxOs
     ... 10                0
     ... 100               0
     ... 1000              0
     ... 10000             1
     ... 100000            0
     ... 1000000           2
     ... 10000000          1
     ... 100000000         2
     ... 1000000000        2
     ... 10000000000       11
     ... 100000000000      18
     ... 1000000000000     1
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Seq 0.2% Wallet
  restorationTime: 510.7 s
  listingAddressesTime: 35.70 ms
  estimatingFeesTime: 39.94 ms
  utxoStatistics:
    = Total value of 6462355327839 lovelace across 86 UTxOs
     ... 10                1
     ... 100               1
     ... 1000              1
     ... 10000             1
     ... 100000            2
     ... 1000000           3
     ... 10000000          1
     ... 100000000         4
     ... 1000000000        2
     ... 10000000000       26
     ... 100000000000      42
     ... 1000000000000     2
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

BenchResults:
  qualifier: Seq 0.4% Wallet
  restorationTime: 551.5 s
  listingAddressesTime: 61.45 ms
  estimatingFeesTime: 66.49 ms
  utxoStatistics:
    = Total value of 15179718492947 lovelace across 219 UTxOs
     ... 10                1
     ... 100               3
     ... 1000              1
     ... 10000             3
     ... 100000            8
     ... 1000000           4
     ... 10000000          6
     ... 100000000         19
     ... 1000000000        14
     ... 10000000000       59
     ... 100000000000      96
     ... 1000000000000     5
     ... 10000000000000    0
     ... 100000000000000   0
     ... 1000000000000000  0
     ... 10000000000000000 0
     ... 45000000000000000 0

[jonathanknowles]

Suggested change

	-- recognize as ours. It is expressed in tenth of percents, so "1" means 0.1%,
	-- "10" means 1% and 1000 means 100%.
	-- recognize as ours. It is expressed in tenths of a percent, so "1" means 0.1%,
	-- "10" means 1%, and 1000 means 100%.

There is also per mille, but it is rarely used in English, so I wouldn't recommend it. 😸

[jonathanknowles]

Suggested change

	-- recognize as ours. It is expressed in tenth of percents, so "1" means 0.1%,
	-- "10" means 1% and 1000 means 100%.
	-- recognize as ours. It is expressed in tenths of a percent, so "1" means 0.1%,
	-- "10" means 1%, and 1000 means 100%.

[jonathanknowles]

Perhaps this is a bit easier to read:

Suggested change

	p = floor (double (maxBound :: Word32) * double (natVal (Proxy @p)) / 1000)
	p = floor
	$ double (maxBound :: Word32)
	* double (natVal (Proxy @p))
	/ 1000

[KtorZ]

I disagree :), although I admit this could be more readable. What about:

        p = floor (double sup * double (natVal (Proxy @p)) / 1000)
          where
            sup = maxBound :: Word32 

[jonathanknowles]

What about:

        p = floor (double sup * double (natVal (Proxy @p)) / 1000)
          where
            sup = maxBound :: Word32 

I think this is an improvement. I'm guessing sup is short for "superior" ("borne supérieure")?

Perhaps we could also give natVal (Proxy @p) a name, and then we'd have:

        p = floor ((double sup * double den) / 1000)
          where
            sup = maxBound :: Word32
            den = natVal (Proxy @p) 

Or:

        p = floor ((double n * double d) / 1000)
          where
            n = maxBound :: Word32
            d = natVal (Proxy @p) 

(where n and d are numerator and denominator, respectively).

[KtorZ]

I agree, although I think the line is already very readable :)

[jonathanknowles]

Suggested change

	-- it discover addresses based on an arbitrary ratio instead of respecting the
	-- BIP-44 discovery.
	-- it discovers addresses based on an arbitrary ratio instead of respecting
	-- BIP-44 discovery.

[KtorZ]

@jonathanknowles comments' typos fixed and made the definition of p more readable!

[jonathanknowles]

Suggested change

	-- recognize as ours. It is expressed in tenths of percent, so "1" means 0.1%,
	-- recognize as ours. It is expressed in tenths of a percent, so "1" means 0.1%,

[jonathanknowles]

Suggested change

	-- recognize as ours. It is expressed in tenths of percent, so "1" means 0.1%,
	-- recognize as ours. It is expressed in tenths of a percent, so "1" means 0.1%,

[jonathanknowles]

What about:

        p = floor (double sup * double (natVal (Proxy @p)) / 1000)
          where
            sup = maxBound :: Word32 

I think this is an improvement. I'm guessing sup is short for "superior" ("borne supérieure")?

Perhaps we could also give natVal (Proxy @p) a name, and then we'd have:

        p = floor ((double sup * double den) / 1000)
          where
            sup = maxBound :: Word32
            den = natVal (Proxy @p) 

Or:

        p = floor ((double n * double d) / 1000)
          where
            n = maxBound :: Word32
            d = natVal (Proxy @p) 

(where n and d are numerator and denominator, respectively).

[jonathanknowles]

@jonathanknowles comments' typos fixed and made the definition of p more readable!

Thanks for fixing these! I added a couple more suggestions (as I think there is still an "a" missing from a couple of these comments).

[Anviking]

lgtm

[KtorZ]

bors r+

[iohk-bors]

Canceled

[KtorZ]

bors r+

[iohk-bors]

Build succeeded

• buildkite/cardano-wallet
• ci/hydra-build:required