Return descriptive 503 when listing stake pools with uncomplete sync

[hasufell]

Wrt #1971

[jonathanknowles]

Looks good so far. 👍

I've added some suggestions in the comments.

There are still some issues with formatting to address. (See comments.)

[piotr-iohk]

@hasufell I have taken your branch (hasufell:hasufell/1971/fix-err-list-stakepools) for a little spin and I actually still see the same behavior as -> #1971 (comment) 🤔

Still see 500 and "Somenthing went wrong" on listing stake pools while wallet is syncing through Byron era. (Checked on testnet)

(btw, is there a reason why you are using your fork of cardano-wallet instead of using main repo?)

[hasufell]

I can reproduce. This is the problem as described in #1971 (comment)

It's hard to say where this exception leaks to.

[hasufell]

@piotr-iohk should be fixed, please retry

[jonathanknowles]

Hi @hasufell

There are still some issues with coding style.

In a previous review, I made these requested changes, and they were marked as resolved, but they don't seem to be have been fixed (or if they were, perhaps the fixes were reverted by a subsequent push?):

• https://github.com/input-output-hk/cardano-wallet/pull/2094/files#r480718996
• https://github.com/input-output-hk/cardano-wallet/pull/2094/files#r480723300
• https://github.com/input-output-hk/cardano-wallet/pull/2094/files#r480716728

Please could you address these issues?

As I mentioned before, I would love to be able to give you a tool that could automatically apply the correct format, but I don't have one. If you'd like to explore automated solutions such as brittany, I would not be opposed. But that requires a team discussion which is outside the scope of this PR.

Given that our team does not yet use an automated tool, team members generally make a best effort to make their code follow the standard. Could you do that? I don't think it's too hard to follow given that it's rather short, and only has a few rules. We provide an .editor file to make this easier, so the burden should not be too arduous.

As a reminder:

• The purpose of having a written standard is to record things that the team has agreed on, so discussions about style can be avoided during PR reviews.
• The benefit is that we can concentrate on more important issues during PR reviews, such as functionality and correctness.
• Rules are added to the standard as the result of team discussions and voting. The standard is a consensus that we've worked out over time.

We allow ourselves the flexibility to occasionally break our own standard if there is good reason. But I don't think that this flexibility should be interpreted as licence to not follow the standard (on the basis that there is no automated tool), especially when the reviewer has gone to the effort of providing suggestions and feedback.

Thank-you.

[hasufell]

Hi @jonathanknowles ,

thank you very much for your detailed explanation!

I believe there must be a misunderstanding though. I wasn't arguing against the coding standard in any of my PRs I believe, nor have I indicated that I don't intend to follow it. In fact I've spent a great deal of time configuring my editor, filing bug reports on various vim plugins and reading through stylish-haskell documentation in order to figure out if some of this can be automated (because we already use this tool). I'm using the .editorconfig since the first week, but it doesn't do much.

Maybe you're faster at pattern recognition and adapting to different coding styles. I personally am not and I've never worked with this coding style, so I'm afraid it will take more time before my PRs will satisfy your standards, unless this will be automated. Please bear with me.

Thanks for your time reviewing these points!

[piotr-iohk]

@piotr-iohk should be fixed, please retry

LGTM.

GET http://localhost:8090/v2/stake-pools?stake=1000000000

The response was:
Code = 503,
Message = {"code":"past_horizon","message":"Tried to convert something that is past the horizon (due to uncertainty about the next hard fork). Wait for the node to finish syncing to the hard fork. Depending on the blockchain, this process can take an unknown amount of time."}

code has been adjusted accordingly 👍

[hasufell]

bors r+

[iohk-bors]

This PR was included in a batch with a merge conflict, it will be automatically retried

[iohk-bors]

Merge conflict

[hasufell]

bors r+

[iohk-bors]

This PR was included in a batch with a merge conflict, it will be automatically retried

[iohk-bors]

Build failed

• buildkite/cardano-wallet

[KtorZ]

bors r+

[iohk-bors]

Build failed

• buildkite/cardano-wallet

[hasufell]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required