Include transaction metadata in coin selection and fee calculations #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
ADDING FEATURE
This was referenced Sep 2, 2020
KtorZ
approved these changes
Sep 2, 2020
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
1 similar comment
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
Merge conflict |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
2096: Tx metadata API integration tests r=KtorZ a=rvl ### Issue Number ADP-307 / #2074 / #2073. ### Overview - API test case for posting a transaction with metadata. - Test creating a transaction with invalid metadata. - Test creating a transaction that's too large due to metadata. - Test that the transaction fee estimate is higher when there's metadata in the transaction. ### Comments - Based on PR #2104 branch. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
2096: Tx metadata API integration tests r=KtorZ a=rvl ### Issue Number ADP-307 / #2074 / #2073. ### Overview - API test case for posting a transaction with metadata. - Test creating a transaction with invalid metadata. - Test creating a transaction that's too large due to metadata. - Test that the transaction fee estimate is higher when there's metadata in the transaction. ### Comments - Based on PR #2104 branch. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
|
superseded by #2096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-307 / #2075
Overview
Adds metadata as a parameter of coin selection and fee calculation functions.
Comments