Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx metadata tests #2110

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Tx metadata tests #2110

merged 4 commits into from
Sep 4, 2020

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Sep 3, 2020 •
edited
Loading

Issue Number

#2075
#2074

Overview

  • 8a1b1eb
    Extend tx with meta test to check if metadata available on tx list and tx get

  • a90cefa
    Additional tests for fee estimation with metadata

Comments

TRANSMETA_CREATE_03, TRANSMETA_ESTIMATE_03 - are currently failing -> #2075 (comment).

@piotr-iohk piotr-iohk added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Sep 3, 2020
@piotr-iohk piotr-iohk requested a review from rvl September 3, 2020 11:29
@piotr-iohk piotr-iohk self-assigned this Sep 3, 2020
@piotr-iohk piotr-iohk mentioned this pull request Sep 3, 2020
Closed
rvl
rvl approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@piotr-iohk
Copy link
Contributor Author

Unfortunately two tests are failing (#2075 (comment)). The ones with too big metadata:

TRANSMETA_CREATE_03,
TRANSMETA_ESTIMATE_03

@KtorZ
Copy link
Member

KtorZ commented Sep 3, 2020

*fixed ☝️ , pushing in a bit, I merged two errors cases (I didn't notice yesterday we already had a TxIsTooBig error code ... so we now have both with TxTooLarge :s), so some other integration tests may need adjustment.

@rvl
Copy link
Contributor

rvl commented Sep 4, 2020

Thanks!

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 4, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit d528050 into master Sep 4, 2020
@iohk-bors iohk-bors bot deleted the piotr/tx_meta_tests branch September 4, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-307) Transaction metadata
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotr-iohk @KtorZ @rvl